[issue17652] Add skip_on_windows decorator to test.support

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17652] Add skip_on_windows decorator to test.support

STINNER Victor added the comment: It might be interesting to see a patch that converts current @skipIf(sys.platform == 'win32' or os.name == 'nt') instances to @skip_on_windows to see just what kind of difference it makes, but I'm honestly more interested in seeing how many different ways

[issue17652] Add skip_on_windows decorator to test.support

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17652 ___ ___ Python-bugs-list

[issue17652] Add skip_on_windows decorator to test.support

Zachary Ware added the comment: The patch looks fine, but I don't see a big gain from it; call me +0. It might be interesting to see a patch that converts current @skipIf(sys.platform == 'win32' or os.name == 'nt') instances to @skip_on_windows to see just what kind of difference it makes,

[issue17652] Add skip_on_windows decorator to test.support

Mark Lawrence added the comment: I like the idea and the patch looks clean so can we have a commit review please. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17652

[issue17652] Add skip_on_windows decorator to test.support

Changes by Brian Curtin br...@python.org: -- nosy: -brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17652 ___ ___ Python-bugs-list

[issue17652] Add skip_on_windows decorator to test.support

Berker Peksag added the comment: Could you also propose places in the test to use this? Sure. - Lib/test/test_py_compile.py - Lib/test/test_cmd_line.py - Lib/test/test_faulthandler.py - Lib/test/test_subprocess.py - Lib/test/test_fileio.py - Lib/test/test_io.py - Lib/test/test_logging.py -

[issue17652] Add skip_on_windows decorator to test.support

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +brian.curtin stage: - patch review type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17652 ___

[issue17652] Add skip_on_windows decorator to test.support

Brian Curtin added the comment: Could you also propose places in the test to use this? If we're going to add it, we should use it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17652 ___

[issue17652] Add skip_on_windows decorator to test.support

New submission from Berker Peksag: I saw a conversation about adding a @skip_on_windows decorator on #python-dev a couple of months ago. Attached a patch with a documentation update. (Added the participants of the conversation to nosy list.) -- components: Tests files: