Roundup Robot added the comment:
New changeset 193e7ad92900 by Vinay Sajip in branch 'default':
Issue #17713: Added failure diagnostics to test.
http://hg.python.org/cpython/rev/193e7ad92900
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 1494daf809c1 by Vinay Sajip in branch 'default':
Closes #17713: Fixed bug in test_compute_rollover_weekly_attime.
http://hg.python.org/cpython/rev/1494daf809c1
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
Roundup Robot added the comment:
New changeset efda51b85b31 by Vinay Sajip in branch 'default':
Issue #17713: additional tweak to test.
http://hg.python.org/cpython/rev/efda51b85b31
--
___
Python tracker rep...@bugs.python.org
New submission from Ned Batchelder:
I just pulled down the tip of CPython, built it, and ran the tests, and got
this failure:
```
==
FAIL: test_compute_rollover_weekly_attime
(test.test_logging.TimedRotatingFileHandlerTest)
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +vinay.sajip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17713
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 185ae0c95e5b by Vinay Sajip in branch 'default':
Issue #17713: Test temporarily skipped while failure investigated.
http://hg.python.org/cpython/rev/185ae0c95e5b
--
nosy: +python-dev
___
Python tracker
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk:
--
assignee: - vinay.sajip
components: +Library (Lib)
type: - behavior
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17713
Shaun Hickson added the comment:
I was looking at this yesterday and this morning a little bit, and the expected
value is too large by a day (e.g. as the test currently runs, actual = expected
- (24 * 60 * 60)).
--
nosy: +sphickson
___
Python
Shaun Hickson added the comment:
Patch to fix test_compute_rollover_weekly_attime:
1) Use 6 rather than 7 for calculating expected rollover day
2) Roll all cases (rollover day earlier than current day, both days the same,
and current day earlier than rollover day) into one if/else statement
Antoine Pitrou added the comment:
Shaun, your patch fails if I remove the @skip decorator:
==
FAIL: test_compute_rollover_weekly_attime
(test.test_logging.TimedRotatingFileHandlerTest)
Antoine Pitrou added the comment:
I also find the original code totally unreadable. Why currentTime = 0? Why no
comments on the various calculations? Vinay, it would be nice if you could make
some efforts here.
--
___
Python tracker
11 matches
Mail list logo
