Roundup Robot added the comment:
New changeset 599a957038fa by Serhiy Storchaka in branch 'default':
Removed redundant casts to `char *`.
https://hg.python.org/cpython/rev/599a957038fa
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 3055e61f1e66 by Serhiy Storchaka in branch 'default':
Issue #1772673: The type of `char*` arguments now changed to `const char*`.
http://hg.python.org/cpython/rev/3055e61f1e66
--
nosy: +python-dev
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1772673
Ned Deily added the comment:
Compile errors on OS X 10.8 with clang:
cc -Wno-unused-result -Werror=declaration-after-statement -g -O0 -Wall
-Wstrict-prototypes -I. -IInclude -I../../source/Include-DPy_BUILD_CORE
-c ../../source/Modules/posixmodule.c -o Modules/posixmodule.o
In file
Roundup Robot added the comment:
New changeset 8bd69bd6e129 by Serhiy Storchaka in branch 'default':
Restore prototypes for the 'openpty' and 'forkpty' on BSDI (broken in issue
#1772673).
http://hg.python.org/cpython/rev/8bd69bd6e129
--
___
Python
Serhiy Storchaka added the comment:
The patch synchronized with tip.
--
Added file: http://bugs.python.org/file32124/const_char_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1772673
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +tim.peters
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1772673
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1772673
___
___
Changes by Eli Bendersky eli...@gmail.com:
--
nosy: -eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1772673
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
The patch is outdated. Some function prototypes were changed in issue9369, some
were changed before.
Here is a new patch. It adds const qualifier to following public functions:
PyObject_DelAttrString, PyObject_HasAttrString, PyObject_GetAttrString,
Serhiy Storchaka added the comment:
See also issue9369.
--
dependencies: +const char* for PyObject_CallMethod and PyObject_CallFunction
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1772673
Serhiy Storchaka added the comment:
In C++ we may overload functions for backward compatibility:
PyAPI_FUNC(int) PyArg_ParseTupleAndKeywords(PyObject *, PyObject *,
const char *, const char * const *, ...);
PyAPI_FUNC(int) PyArg_VaParseTupleAndKeywords(PyObject *,
Eli Bendersky added the comment:
For external APIs visible to user code, this can cause some compatibility
problems and users may need to at the very least re-compile this code. So -1
here.
For new external APIs, having const wherever appropriate should be considered
on a case by case basis.
Antoine Pitrou added the comment:
For external APIs visible to user code, this can cause some
compatibility problems and users may need to at the very least
re-compile this code.
Can you explain exactly which compatibility problems this would cause?
Actually, the point is precisely to make
Eli Bendersky added the comment:
Antoine, I was referring to the discussion linked earlier
(http://mail.python.org/pipermail/python-dev/2006-February/060689.html). Users
of the C API needed to recompile their code and also add preprocessor hacks to
make things compatible with C and C++,
Antoine Pitrou added the comment:
Antoine, I was referring to the discussion linked earlier
(http://mail.python.org/pipermail/python-dev/2006-February/060689.html).
Ok, I've read it through. The problem is specifically with
pointers-to-pointers:
Changes by Daniel Diniz aja...@gmail.com:
--
dependencies: +replacing char* with const char* in sysmodule.c/.h
versions: +Python 2.7 -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1772673
Alexander Belopolsky added the comment:
Douglas Greiman submitted many similar changes with his issue2135 patch.
His patch also amends documentation, which is missing here.
I am adding dgreiman to the nosy list here to avoid duplication of
effort.
I am -0 on the idea.
--
nosy:
Changes by Christian Heimes:
--
type: - rfe
versions: +Python 2.6
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1772673
_
___
Python-bugs-list mailing list
Amaury Forgeot d'Arc added the comment:
There was once a rather long discussion about const in
PyArg_ParseTupleAndKeywords:
http://mail.python.org/pipermail/python-dev/2006-February/060689.html
If you don't read it to the end, here is the conclusion:
It sounds like the right answer for Python
20 matches
Mail list logo
