[issue17765] weakref.ref ignores a 'callback' keyword argument

2016-05-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Done. This issue is similar to recently closed issue26822. Please give me know if you have other ready to review patches. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python

[issue17765] weakref.ref ignores a 'callback' keyword argument

2016-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset ee17a83feabc by Serhiy Storchaka in branch '3.5': Issue #17765: weakref.ref() no longer silently ignores keyword arguments. https://hg.python.org/cpython/rev/ee17a83feabc New changeset 60de9c6188cc by Serhiy Storchaka in branch '2.7': Issue #17765:

[issue17765] weakref.ref ignores a 'callback' keyword argument

2016-05-07 Thread Georg Brandl
Georg Brandl added the comment: Serhiy, feel free to go ahead and commit, I don't have my keys with me ATM. -- ___ Python tracker ___

[issue17765] weakref.ref ignores a 'callback' keyword argument

2016-05-06 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> georg.brandl ___ Python tracker ___ ___

[issue17765] weakref.ref ignores a 'callback' keyword argument

2016-05-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: no_weakref_kwargs_2.patch LGTM. -- components: +Extension Modules nosy: +serhiy.storchaka stage: needs patch -> commit review type: enhancement -> behavior versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4

[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Georg Brandl
Georg Brandl added the comment: See attached patch, it handles this like all other builtins that don't support keyword arguments in their constructor. -- keywords: +patch nosy: +georg.brandl, pitrou versions: +Python 2.7, Python 3.3 Added file:

[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Why the PyWeakref_Check() in your patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17765 ___ ___

[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Georg Brandl
Georg Brandl added the comment: Good point, that is pointless in __init__(). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17765 ___ ___

[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Georg Brandl
Changes by Georg Brandl ge...@python.org: Added file: http://bugs.python.org/file32119/no_weakref_kwargs_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17765 ___

[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-04-16 Thread Mark Dickinson
New submission from Mark Dickinson: Passing a weakref.ref callback by keyword currently fails silently: Python 3.4.0a0 (default:537c1f1ab53c, Apr 16 2013, 20:07:47) [GCC 4.2.1 (Apple Inc. build 5664)] on darwin Type help, copyright, credits or license for more information. import weakref