Ezio Melotti added the comment:
I think this can be closed, since #4147 already improved tpprettyxml().
--
nosy: +ezio.melotti
resolution: - out of date
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Dávid Gábor Bodor david.gabor.bo...@gmail.com added the comment:
I would prefer to see this improvement as an option, rather than the default,
because I believe that 'Issue4147' satisfies pretty printing better.
While leaving out whitespace from text-only elements is benefical for
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: -terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1777134
___
___
Python-bugs-list
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Looking at the comments here msg104801 seems like more work needs to be done on
the patch.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1777134
Changes by Terry J. Reedy tjre...@udel.edu:
Removed file: http://bugs.python.org/file13043/unnamed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1777134
___
Terry J. Reedy tjre...@udel.edu added the comment:
Removed junk copy of message
--
nosy: +tjreedy
versions: +Python 3.2 -Python 2.6, Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1777134
Tres Seaver tsea...@agendaless.com added the comment:
The patch applies cleanly to the 2.6 branch, and with minimal fuzz to
the trunk. Exsting tests pass in both cases, as does the new test.
The added testcase seems plainly correct.
The first hunk of the diff to Lib/xml/dom/minidom.py is a
Daniel Diniz aja...@gmail.com added the comment:
@Roy: we can try :)
Patch updated, tests pass. However, keeping the default output and
adding an option to prettyprint should keep lots of current users sane,
while those wanting prettier output could have it.
--
keywords: +easy
nosy:
Roy Wood roy.w...@gmail.com added the comment:
Thanks! :-)
On Wed, Feb 11, 2009 at 9:28 PM, Daniel Diniz rep...@bugs.python.orgwrote:
Daniel Diniz aja...@gmail.com added the comment:
@Roy: we can try :)
Patch updated, tests pass. However, keeping the default output and
adding an option
Roy Wood roy.w...@gmail.com added the comment:
This patch would be very useful to me, so I'm sad to see it's been
languishing for so long. :-(
Is there any way to encourage the maintainer to merge this into the
current branch?
--
nosy: +rrwood
___
Changes by Gabriel Genellina gagsl-...@yahoo.com.ar:
--
nosy: +gagenellina
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1777134
___
___
Teajay added the comment:
Thanks for the feedback. I looked at the issues you mentionned and tried
to sort that out. You might want to have a look it this new patch. I ran
the tests, added a new test case and hopefully managed to get the code
style right this time :-)
Let me know if there is
Virgil Dupras added the comment:
If the patch would have better styling (if(onetextnode == True):), correct
the test it breaks, and even better, add new ones, I guess it
would be an acceptable one.
--
nosy: +vdupras
_
Tracker [EMAIL PROTECTED]
John-Mark Gurney added the comment:
I think this is a good patch. It gives more useful pretty XML output.
I would suggest that possibly this routine be moved to xml.dom or
xml.dom.utils instead of being part of minidom since it should not be
minidom specific.
There is one bug in the patch in
14 matches
Mail list logo
