[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Changes by Martin Panter : Added file: http://bugs.python.org/file30108/7691d1d4b955.diff ___ Python tracker ___

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

paul j3 added the comment: I just submitted a patch to http://bugs.python.org/issue11874 that substantially rewrites _format_actions_usage(). It generates the group and action parts separately, and does not do the kind of cleanup that produces this issue. --

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

R. David Murray added the comment: I've been observing the activity on the argparse issues and am appreciating the work, but I don't have time right now to review the patches. I should have more time next month, and expect to get to them then, if no one else gets to them before I do.

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Yogesh Chaudhari added the comment: @Terry: Thanks for the info. I seem to have the elusive * after my username now. I am not sure how this works, but can you review/test/apply the patch now? -- ___ Python tracker rep...@bugs.python.org

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Terry J. Reedy added the comment: Argparse is out of my area of competence/experience. I have added a couple of people who have worked on argparse in the past and should be better able to review or suggest another reviewer. -- nosy: +bethard, r.david.murray

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

paul j3 added the comment: I'm following a dozen argparse issues with patches. I haven't seen much posting by argparse experts (like bethard, david.murry) since last December. -- ___ Python tracker rep...@bugs.python.org

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Yogesh Chaudhari added the comment: @terry and @paul: I have 2 argparse related patches, sitting idle for quiet sometime now. Can you suggest any more names who can take this forward? (I could not find anyone else related to argparse in http://docs.python.org/devguide/experts.html) --

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Yogesh Chaudhari added the comment: I am not sure if I am missing something. I had filled out the form at http://www.python.org/psf/contrib/contrib-form/ on the day I submitted the patch and even got back an email from Ewa Jodlowska. However, I don't see any * after my name. I submitted the

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Terry J. Reedy added the comment: Wait a week and see what happens. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17890 ___ ___

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Yogesh Chaudhari added the comment: A user generated line with multiple spaces may be essential if we are getting the usage data (particularly from) a csv file (that may have random spaces in certain fields) or some other form of stored or auto-generated data. --

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

paul j3 added the comment: I see three solutions - 1) gholms' patch which removes '() ' and [] ' 2) Yogesh's patch which removes all duplicated spaces. 3) remove the 2 asserts. The first 2 do the same thing most of the time, but may differ if the user somehow inserts spaces into names.

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Terry J. Reedy added the comment: Garrett and Yogesh, please submit contributor license agreements http://www.python.org/psf/contrib/contrib-form/ if you have not yet. When one is properly recorded, a * appears after your name. -- nosy: +terry.reedy versions: +Python 3.3

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

paul j3 added the comment: Looks like the text = text.strip() at the end of the set of regex (in _format_actions_usage) needs to be replaced with something that removes all excess spaces, e.g. text = _re.sub( '\s+', ' ', text ).strip() -- nosy: +paul.j3

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Changes by Yogesh Chaudhari mr.yog...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file30108/7691d1d4b955.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17890 ___

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Yogesh Chaudhari added the comment: Made similar required changes for version 2.7 -- nosy: +Yogesh.Chaudhari Added file: http://bugs.python.org/file30110/Issue17890-27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17890

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Changes by Yogesh Chaudhari mr.yog...@gmail.com: Removed file: http://bugs.python.org/file30108/7691d1d4b955.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17890 ___

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

paul j3 added the comment: In the test case: class TestMutuallyExclusiveManySuppressed even with a short 'eggs' argument, there is a difference Old usage would be: usage: PROG [-h] [--eggs EGGS] new usage: PROG [-h] [--eggs EGGS] i.e. 2 v 1 space. But extra spaces are not as dramatic a

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

New submission from Garrett Holmstrom: When it goes to format a usage message, argparse seems to (correctly) fail to satisfy one of its assertions when all of the following are true: 1. A mutually exclusive group contains only args that are suppressed 2. An unsuppressed arg follows that group

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

Changes by Garrett Holmstrom gho...@devzero.com: -- hgrepos: +187 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17890 ___ ___ Python-bugs-list