[issue17905] Add check for locale.h

Changes by Roman Evstifeev : -- nosy: +Roman.Evstifeev ___ Python tracker ___ ___

[issue17905] Add check for locale.h

Stefan Krah added the comment: I think all locale includes are unguarded now. -- ___ Python tracker ___ ___

[issue17905] Add check for locale.h

Roundup Robot added the comment: New changeset cc501d439239 by Stefan Krah in branch 'default': Issue #17905: Do not guard locale include with HAVE_LANGINFO_H. https://hg.python.org/cpython/rev/cc501d439239 -- nosy: +python-dev ___ Python tracker

[issue17905] Add check for locale.h

Stefan Krah added the comment: Okay, closing as a duplicate (the second patch here that checks for locale.h seems too broad to me since it's a standard header). -- nosy: +skrah resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Interpreter fails in

[issue17905] Add check for locale.h

Xavier de Gaye added the comment: Android API level 21 has a full fledged locale.h now. There is still no langinfo.h, this issue is a duplicate of issue #22747. -- nosy: +xdegaye ___ Python tracker

[issue17905] Add check for locale.h

Antoine Pitrou added the comment: There are more places where including locale.h is guarded by HAVE_LANGINFO_H. Also, there are places where including locale.h isn't guarded by anything (such as Python/formatter_unicode.c), so I don't think we need the new configure check. -- nosy:

[issue17905] Add check for locale.h

Antonio Cavallo added the comment: I see, in that case wouldn't make more sense completely remove the check for the langinfo.h either? I think is better to close the issue to keep the noise low. Thanks -- resolution: - works for me status: open - closed

[issue17905] Add check for locale.h

Antoine Pitrou added the comment: You might have misunderstood me. Since locale.h appears to exist on all systems (including Android) there's no need to add a check for it in configure. On the other hand, it is correct to fix the existing guards like your patch proposes to do, except that

[issue17905] Add check for locale.h

Antonio Cavallo added the comment: ok I see it, thanks. I've attached a new patch fixing the files with the locale's guards. Modules/readline.c might have the SAVE_LOCALE renamed into HAVE_SETLOCALE but the patch doesn't address that bit. Android has definitively locale.h but it is a dummy

[issue17905] Add check for locale.h

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17905 ___ ___ Python-bugs-list

[issue17905] Add check for locale.h

New submission from Antonio Cavallo: This patch adds autoconf.ac check for the locale.h file in addition to langinfo.h. The patch contains also a fix to Python/fileutils.c file. The android ndk provides locale.h but no langinfo.h: this fixes the issue. BTW bionic doesn't have any runtime