[issue18010] pydoc search chokes on import errors

Roundup Robot added the comment: New changeset 1ab20d3c9dc6 by Martin Panter in branch '2.7': Issue #18010: Fix pydoc GUI search to handle package exceptions https://hg.python.org/cpython/rev/1ab20d3c9dc6 -- ___ Python tracker

[issue18010] pydoc search chokes on import errors

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue18010] pydoc search chokes on import errors

Serhiy Storchaka added the comment: Oh, I were not expected that the test will be so complex, and now I'm not sure that want it. :-( But looks it can't be written simpler. The patch LGTM in any case. -- ___ Python tracker

[issue18010] pydoc search chokes on import errors

Changes by Serhiy Storchaka : -- stage: patch review -> commit review ___ Python tracker ___

[issue18010] pydoc search chokes on import errors

Roundup Robot added the comment: New changeset 9098731de840 by Martin Panter in branch '3.4': Issue #18010: Fix pydoc web server search to handle package exceptions https://hg.python.org/cpython/rev/9098731de840 New changeset 8702efa1feb4 by Martin Panter in branch '3.5': Issue #18010: Merge

[issue18010] pydoc search chokes on import errors

Martin Panter added the comment: In Python 2, it looks like instead of the web server search function there is a GUI search function. Here is a patch to fix the equivalent problem there. However I am not volunteering to make a test case; there does not seem to be any GUI tests to start with.

[issue18010] pydoc search chokes on import errors

Serhiy Storchaka added the comment: gui-search.patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list

[issue18010] pydoc search chokes on import errors

Martin Panter added the comment: Here is a test case. I had to insert a temporary directory into sys.path, based off my patch in Issue 25184. Let me know if it doesn’t look too evil :) -- nosy: +martin.panter stage: test needed -> patch review Added file:

[issue18010] pydoc search chokes on import errors

Changes by Serhiy Storchaka : -- stage: needs patch -> test needed versions: +Python 3.5, Python 3.6 -Python 3.3 ___ Python tracker

[issue18010] pydoc search chokes on import errors

Raymond Hettinger added the comment: The patch looks good. -- nosy: +rhettinger ___ Python tracker ___ ___

[issue18010] pydoc search chokes on import errors

Serhiy Storchaka added the comment: Would be nice to have a test. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue18010] pydoc search chokes on import errors

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: -serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18010 ___ ___

[issue18010] pydoc search chokes on import errors

New submission from Antoine Pitrou: After installing Django, I get the following error in test_pydoc: == FAIL: test_url_requests (test.test_pydoc.PydocUrlHandlerTest)

[issue18010] pydoc search chokes on import errors

Serhiy Storchaka added the comment: Isn't issue10060 related? -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18010 ___

[issue18010] pydoc search chokes on import errors

Antoine Pitrou added the comment: Not exactly. issue10060 is about a crash when loading an extension module, not an exception being raised and propagated through pydoc. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18010

[issue18010] pydoc search chokes on import errors

Antoine Pitrou added the comment: Patch attached. -- keywords: +patch Added file: http://bugs.python.org/file30306/pydoc_search_onerror.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18010