[issue18115] Use importlib.util.module_to_load in all loaders in importlib

Changes by Brett Cannon : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18115] Use importlib.util.module_to_load in all loaders in importlib

Roundup Robot added the comment: New changeset 205aa49e5cd5 by Brett Cannon in branch 'default': Issue #18115: Abstract out managing the cleanup of modules to use in http://hg.python.org/cpython/rev/205aa49e5cd5 -- nosy: +python-dev ___ Python tracker

[issue18115] Use importlib.util.module_to_load in all loaders in importlib

Brett Cannon added the comment: Turns out BuiltinImporter doesn't like having a pre-existing module, so a new keyword argument will be necessary to allow for only the cleanup code to run and not the construction of a new module. -- ___ Python tracke

[issue18115] Use importlib.util.module_to_load in all loaders in importlib

New submission from Brett Cannon: BuiltinImporter, FrozenImporter, and ExtensionFileLoader all have their own custom code to manage clearing sys.modules if something goes wrong. Should see if any of them would break if they used importlib.util.module_to_load. And if they would break thanks to