Christian Heimes added the comment:
Thx for the fix!
--
nosy: +christian.heimes
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18178
Roundup Robot added the comment:
New changeset f09ca52747a6 by Christian Heimes in branch '3.3':
Issue #18178: Fix ctypes on BSD. dlmalloc.c was compiled twice which broke
malloc weak symbols.
http://hg.python.org/cpython/rev/f09ca52747a6
New changeset bea2f12e899e by Christian Heimes in
koobs added the comment:
Commit looks good, confirming test suite passing for 3.x, 3.3 and 2.7.on
http://buildbot.python.org/all/buildslaves/koobs-freebsd10
Thank you for picking this up and finishing it off Christian.
--
___
Python tracker
koobs added the comment:
I've added a new FreeBSD 10.0-CURRENT buildbot to the pool (thanks antoine)
that reproduces the issue and should provide sufficient coverage for testing
the proposed patch:
http://buildbot.python.org/all/buildslaves/koobs-freebsd10
I'll upgrade the FreeBSD 9-STABLE
New submission from rm:
Hello.
Marcel Moolenaar (mar...@freebsd.org) pointed this out after committing FreeBSD
revision 250991 [1], that makes the malloc(3) family of functions weak symbols.
I'm citing him, because (silly me) I don't understand all of this completely:
After my commit to
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18178
___
Amaury Forgeot d'Arc added the comment:
Said simpler: dlmalloc.c code is indeed compiled twice:
- once as part of closures.c, which #include dlmalloc.c; this is done
carefully (with 'static' and 'USE_DL_PREFIX') to not clash with standard malloc
functions.
- once as a separate target; without
Alexander Belopolsky added the comment:
I don't have a system affected by the change, but the explanation and the patch
look right to me.
FWIW, the patch applies cleanly to 3.4 head and passes 'make test'.
--
stage: - commit review
versions: +Python 3.3, Python 3.4
