Mark Lawrence added the comment:
@Zach just a reminder that you've committed #18492 in case you'd forgotten this.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18258
Roundup Robot added the comment:
New changeset 27feb652d3ad by Zachary Ware in branch '3.4':
Issue #18258: Fix test discovery for test_codecmaps_*.
http://hg.python.org/cpython/rev/27feb652d3ad
New changeset b08921c7d1ec by Zachary Ware in branch 'default':
Issue #18258: Fix test discovery for
Zachary Ware added the comment:
Not forgotten, just hadn't gotten to on the list yet.
--
assignee: - zach.ware
resolution: - fixed
stage: patch review - resolved
status: open - closed
versions: +Python 3.5 -Python 3.3
___
Python tracker
Zachary Ware added the comment:
Done, issue18492.
I'll submit and updated patch here when (if :)) that one is applied.
I'm also looking into adding resource handling to unittest itself and it is
going pretty well; I hope to have a patch ready for review for that soon.
--
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18258
___
Serhiy Storchaka added the comment:
What is a purpose of `support.use_resources = ['urlfetch']`? I don't see any
effect.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18258
___
R. David Murray added the comment:
It enables the resource when the tests are run via unittest. (That is, it is
equivalent to specifying '-u urlfetch' when running regrtest.)
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
But I don't see any effect.
$ ./python -m test.regrtest -v test_codecmaps_tw
== CPython 3.3.2+ (3.3:359002d4370d+, Jul 14 2013, 15:34:54) [GCC 4.6.3]
== Linux-3.8.0-27-generic-i686-with-debian-wheezy-sid little-endian
==
R. David Murray added the comment:
I'm sorry, I misspoke. It only works when you run the test file as command:
./python Lib/test/test_codecmaps_cn.py
(which uses unittest.main, thus my error in calling it 'via unittest').
So, the fact that the tests don't run if discovery is used is still
Zachary Ware added the comment:
R. David Murray wrote:
So, the fact that the tests don't run if discovery is used is still a
bug. I'm not sure how we fix it, given the nature of the resource.
My preferred solution short of adding resource management to unittest is to add
a regrtest_run flag
R. David Murray added the comment:
+1. You should probably open a new issue for that proposal.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18258
___
New submission from Zachary Ware:
The test package is almost to the point where I can run `PCbuild\python_d.exe
-m unittest discover Lib/test/ test_*.py` and get a useful result, the only
thing that still blows up is multibytecodec_support.py. I had not previously
noticed this problem due to
Changes by Zachary Ware zachary.w...@gmail.com:
--
type: enhancement - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18258
___
___
13 matches
Mail list logo