Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18266
___
Roundup Robot added the comment:
New changeset dd75dbed1135 by Serhiy Storchaka in branch '3.3':
Issue #18266: test_largefile now works with unittest test discovery and
http://hg.python.org/cpython/rev/dd75dbed1135
New changeset 2d8573e12591 by Serhiy Storchaka in branch 'default':
Issue
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18266
Zachary Ware added the comment:
After testing on Windows, here's version 3. This version changes tearDownClass
to truncate the file rather than unlink it, and adds a check to make sure the
file is properly truncated to 0 length. Unlinking the file makes the test take
an extra 40 seconds on
Zachary Ware added the comment:
Here's a stab at fixing that issue. It works, but I don't know that it's the
best solution.
This patch converts test_seek into setUp, and attempts to make sure the test
file is in the same state at the beginning of each test, with a new
tearDownClass removing
Serhiy Storchaka added the comment:
There is other problem with test_largefile. It not allows running only selected
tests. I.e.
./python -m test.regrtest -v -m test_lseek test_largefile
Looks as test_largefile was suboptimal converted to unittest.
--
nosy: +facundobatista,
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18266
___
___
New submission from Zachary Ware:
This one is another inheritance issue. The patch removes unittest.TestCase as
a base for LargeFileTest and converts test_main into setUpModule, load_tests,
and tearDownModule. This seems like the way to go due to the fact that the
order of test execution
