[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

Charles-François Natali added the comment: Fixed, thanks! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

Roundup Robot added the comment: New changeset 330c7aa2922b by Charles-François Natali in branch '3.3': Issue #18308: don't take the scope ID into account when comparing IPv6 http://hg.python.org/cpython/rev/330c7aa2922b New changeset b44749cee660 by Charles-François Natali in branch 'default':

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

David Edelsohn added the comment: The patch in msg192405 works and fixes that error on AIX. That is exactly what I had in mind, but I incorrectly had been looking higher up the class hierarchy to override the method. Thanks! -- ___ Python tracker <

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

STINNER Victor added the comment: "However, it might be simpler to special-case the IPv6 addresses comparison by overriding it in the IPv6 sendmsg base test." Yes, this is why I proposed another approach. (But David convinced me that it is not the right approach.) Victor -- __

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

Charles-François Natali added the comment: > I think the safest solution is not to compare scope_id when comparing > addresses. Agreed. However, it might be simpler to special-case the IPv6 addresses comparison by overriding it in the IPv6 sendmsg base test. Could you try the patch attached?

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

David Edelsohn added the comment: The patch in msg192259 probably will work on the particular AIX system runnnig the buildbot, but I do not believe that the patch is the correct solution for the problem. scope_id 1 is not necessarily the correct link for IPv6 address ::1. The scope_id values

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

STINNER Victor added the comment: "The scope_id in the original bind call defaults to "0", which represents an ambiguous scoped address and allows the IPV6 protocol and implementation to choose the interface or site identifier." Ok, so here is a patch using scope_id=1 to get a reliable IPv6 ad

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

Changes by Antoine Pitrou : -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

David Edelsohn added the comment: The current arguments to checkRecvmsgAddress() are the sockaddrs, so it does not know the protocol family. One potential patch to infer the family and apply the correct test is: diff -r 035d8fed07ad Lib/test/test_socket.py --- a/Lib/test/test_socket.py Tue J

[issue18308] checkRecvmsgAddress wrong in test_socket.py (AIX failures)

New submission from David Edelsohn: The recvmsg tests in test_socket.py check that the address returned by recvmsg matches the original address to which the socket was bound. For IPv6, sockaddr includes sin6_scope_id, in addition to the address and port. The test connects to host "::1", which