[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

miss-islington added the comment: New changeset c0f6f5370325459cadd90010530b1d300dce514e by Miss Islington (bot) in branch '3.7': bpo-18372: Add missing PyObject_GC_Track() calls in the pickle module (GH-8505) https://github.com/python/cpython/commit/c0f6f5370325459cadd90010530b1d300dce514e

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Change by miss-islington : -- pull_requests: +12853 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Inada Naoki added the comment: New changeset 359bd4f61b9e1493081f4f67882554247b53926a by Inada Naoki (Zackery Spytz) in branch 'master': bpo-18372: Add missing PyObject_GC_Track() calls in the pickle module (GH-8505)

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Serhiy Storchaka added the comment: GC support can not be removed, because these objects are created also as long living objects using the standard way. And in this case they are tracked (in PyType_GenericAlloc()) and tp_traverse is called. They are not tracked only when created by an

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

STINNER Victor added the comment: > Tracking objects that do not need this will just add work to the garbage > collector. Not all instances of trackable types should be tracked, for > example the empty tuple and some dicts are not tracked. Well, in that case, we should do the opposite of PR

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Serhiy Storchaka added the comment: Tracking objects that do not need this will just add work to the garbage collector. Not all instances of trackable types should be tracked, for example the empty tuple and some dicts are not tracked. >>> gc.is_tracked(()) False >>> gc.is_tracked((1, 2))

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

STINNER Victor added the comment: It has been decided to not fix the issue in Python 2.7: https://github.com/python/cpython/pull/8505#issuecomment-480771689 -- versions: -Python 3.6 ___ Python tracker

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Change by Zackery Spytz : -- nosy: +ZackerySpytz versions: +Python 3.6, Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Change by Zackery Spytz : -- keywords: +patch pull_requests: +8024 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Mark Lawrence added the comment: @Christian/Victor could either of you provide a patch for this, it's way beyond my knowledge I'm afraid. -- nosy: +BreamoreBoy versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Benjamin Peterson added the comment: Mark, could you please stop touching every issue on the tracker? I appreciate the effort, but giving thoughtful feedback, patches, or reviews on a just a few issues would be much more helpful. -- nosy: +benjamin.peterson

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Mark Lawrence added the comment: Sorry but no, when I started out on this a couple of months ago there were over 600 issues that nobody had even bothered to reply to. That number is now down to 369. I believe that around 200 issues have been closed as a result of my efforts. Do you have a

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Terry J. Reedy added the comment: Mark, I also appreciate your efforts, as I hope should be obvious from my prior responses to many of your other posts. I also agree that somewhat fewer, higher quality posts would be even more helpful. Please do not slip into a 'confrontational' mode, as

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

STINNER Victor added the comment: Le 5 oct. 2014 20:04, Mark Lawrence rep...@bugs.python.org a écrit : Mark Lawrence added the comment: @Christian/Victor could either of you provide a patch for this, it's way beyond my knowledge I'm afraid. I agree with Benjamin. Asking directly two

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

STINNER Victor added the comment: I don't know the PyObject_GC_Track() function. Why is it an issue to not call it? Can you elaborate Christian? What do you suggest? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18372

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Serhiy Storchaka added the comment: From Doc/c-api/gcsupport.rst: Constructors for container types must conform to two rules: #. The memory for the object must be allocated using :c:func:`PyObject_GC_New` or :c:func:`PyObject_GC_NewVar`. #. Once all the fields which may contain

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18372 ___ ___ Python-bugs-list

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

New submission from Christian Heimes: In _Pickler_New() PicklerObject is allocated with self = PyObject_GC_New(PicklerObject, Pickler_Type); but PyObject_GC_Track(self) is never called, same for _Unpickler_New(). I think it's a bug. -- components: Extension Modules messages: