Changes by Ronald Oussoren ronaldousso...@mac.com:
--
assignee: - ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18480
___
___
Roundup Robot added the comment:
New changeset cd4c9d4bd88f by Ronald Oussoren in branch '3.3':
#18480: Add missing PyType_Ready call to _elementtree extension
http://hg.python.org/cpython/rev/cd4c9d4bd88f
New changeset 7362722646f7 by Ronald Oussoren in branch 'default':
(3.3-default): #18480:
Changes by Ronald Oussoren ronaldousso...@mac.com:
--
keywords: -needs review
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18480
Eli Bendersky added the comment:
LGTM, thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18480
___
___
Python-bugs-list mailing list
New submission from Ronald Oussoren:
The _elementtree extension calls PyType_Ready for most, but not all, types
defined in the extension. The attached patch calls PyType_Ready for the
ElementIter_Type.
--
components: Extension Modules, XML
files: elementtree-missing-type-ready.txt
Changes by Ronald Oussoren ronaldousso...@mac.com:
--
keywords: +needs review, patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18480
___
___
Christian Heimes added the comment:
Good catch!
ElementIter_Type has no prototype, too.
$ grep Type Modules/_elementtree.c | grep static
static PyTypeObject Element_Type;
static PyTypeObject Element_Type = {
static PyTypeObject ElementIter_Type = {
static PyTypeObject TreeBuilder_Type;
static
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +eli.bendersky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18480
___
___
Ronald Oussoren added the comment:
It was a pretty easy catch, the _elementtree caused a crash while I was working
on an implementation for PEP 447. The missing call to PyType_Ready helped to
make that implementation more robust :-)
I'm not entirely convinced that adding forward declarations
