[issue18550] internal_setblocking() doesn't check return value of fcntl()

2016-09-08 Thread Christian Heimes
Changes by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2016-09-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0a52c66f31f5 by Christian Heimes in branch 'default': Issue 18550: Check return value of ioctl() / fnctl() in internal_setblocking https://hg.python.org/cpython/rev/0a52c66f31f5 -- nosy: +python-dev ___

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2016-06-12 Thread Christian Heimes
Changes by Christian Heimes : -- assignee: christian.heimes -> ___ Python tracker ___ ___

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2013-11-17 Thread Christian Heimes
Changes by Christian Heimes li...@cheimes.de: -- assignee: - christian.heimes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18550 ___ ___

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2013-10-21 Thread Christian Heimes
Christian Heimes added the comment: LGTM The patch silences the coverity warnings, too. Does anybody else like to do a code review? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18550

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2013-09-02 Thread Ronald Oussoren
Ronald Oussoren added the comment: oops. This should be the right patch. -- Added file: http://bugs.python.org/file31554/issue-18550.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18550

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2013-08-29 Thread Andrew Svetlov
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18550 ___ ___

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2013-08-29 Thread Madison May
Madison May added the comment: The attached patch? :) -- nosy: +madison.may ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18550 ___ ___

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2013-08-01 Thread Ronald Oussoren
Ronald Oussoren added the comment: It's a bit tedious, but not too bad. The attached patch appears to work, but needs review (especially for the Windows and VMS branches in internal_setblocking. This changes the return value of internal_setblocking, it was unconditionally 1 and is now -1 if

[issue18550] internal_setblocking() doesn't check return value of fcntl()

2013-07-24 Thread Christian Heimes
New submission from Christian Heimes: http://hg.python.org/cpython/file/96d817f41c4c/Modules/socketmodule.c#l614 CID 715331 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) 5. check_return: Calling function fcntl(s-sock_fd, 4, delay_flag) without checking return value. This