[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: Python 2.7 is no longer supported. -- resolution: -> out of date stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: BDFL says (http://permalink.gmane.org/gmane.comp.python.devel/146074): Given that the claim Python 2 doesn't support Unicode filenames is factually incorrect (in Python 2.7, most filesystem calls in fact do support Unicode, at least on some platforms), I

[issue18695] os.statvfs() not working well with unicode paths

Giampaolo Rodola' added the comment: Ok, I will go on then. You have eaten return NULL; in posix_mkfifo. What do you mean? If TESTFN_UNICODE.encode(TESTFN_ENCODING) fails (on POSIX locale), it will be better to run tests with unicode(TESTFN, 'ascii') than skip them. Agreed. Tests

[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: You have eaten return NULL; in posix_mkfifo. What do you mean? You deleted return NULL; after if (!PyArg_ParseTuple(...)) in the posix_mkfifo() function. Tests should check that results for unicode filename is same as for str filename. What do you

[issue18695] os.statvfs() not working well with unicode paths

Giampaolo Rodola' added the comment: Either way it's fine with me. Regardless I think these tests have some value because all those os functions are not currently tested so it might makes sense to apply Serhiy's suggestions and port them to Python 3.4. --

[issue18695] os.statvfs() not working well with unicode paths

Giampaolo Rodola' added the comment: Attached patch includes tests. I took test_sax.py as an example. -- Added file: http://bugs.python.org/file33633/issue18695-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18695

[issue18695] os.statvfs() not working well with unicode paths

Giampaolo Rodola' added the comment: While I'm at it I'm going to fix also mkfifo(), mknod() and others. Hold on a bit more. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18695 ___

[issue18695] os.statvfs() not working well with unicode paths

Giampaolo Rodola' added the comment: Ok, patch in attachment fixes mkfifo(), mknod() and statvfs() and also includes Unicode tests for all os module's path-related functions. -- Added file: http://bugs.python.org/file33634/issue18695-3.patch ___

[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: You have eaten return NULL; in posix_mkfifo. from test.test_support import TESTFN_UNICODE, TESTFN_ENCODING can fail. The simplest solution is just initialize them to None by default in test_support. If TESTFN_UNICODE.encode(TESTFN_ENCODING) fails (on POSIX

[issue18695] os.statvfs() not working well with unicode paths

STINNER Victor added the comment: As far as Victor have doubts, we should ask Benjamin. Well, if you begin to patch some os functions, we will find much functions which don't support Unicode path. I prefer to consider that Python 2 doesn't support Unicode filenames to avoid bugs. If you

[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: Giampaolo, do you want to provide a test? -- stage: - test needed type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18695 ___

[issue18695] os.statvfs() not working well with unicode paths

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18695 ___

[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: 2.7.x is a minor version, not 2.7. We fixed Unicode issues in Python 2 bugfixes many times. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18695 ___

[issue18695] os.statvfs() not working well with unicode paths

New submission from Giampaolo Rodola': From: https://code.google.com/p/psutil/issues/detail?id=416 # -*- coding: utf-8 -*- from __future__ import unicode_literals import os, errno name = ƒőő try: os.mkdir(name) except OSError as err: if err.errno != errno.EEXIST: raise

[issue18695] os.statvfs() not working well with unicode paths

Serhiy Storchaka added the comment: Functions such as rename(), popen(), mkfifo(), mknod(), etc have the same issue. -- nosy: +haypo, serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18695

[issue18695] os.statvfs() not working well with unicode paths

STINNER Victor added the comment: The script above works fine on Python 3.3 but on 2.7 you'll get: ... Cool, you now have a good reason to upgrade to Python 3 ;-) I'm not sure that it's a good idea to invest time on fixing Unicode issues in Python 2, especially in a minor version (Python

[issue18695] os.statvfs() not working well with unicode paths

Giampaolo Rodola' added the comment: I'm not sure that it's a good idea to invest time on fixing Unicode issues in Python 2, especially in a minor version (Python 2.7.x). I admit I sort of share the same doubts, but considering 2.7 a minor python version, especially at this point, would be