[issue18778] email docstrings and comments say about Unicode strings

Change by Irit Katriel : -- versions: +Python 3.10, Python 3.11, Python 3.9 -Python 3.3, Python 3.4 ___ Python tracker ___ ___ Pytho

[issue18778] email docstrings and comments say about Unicode strings

R. David Murray added the comment: Yeah, if I could have a do-over of the 3.0 port, I'd probably drop the acceptance of byte strings. Maybe we can deprecate it. -- ___ Python tracker _

[issue18778] email docstrings and comments say about Unicode strings

Serhiy Storchaka added the comment: It is just unusual to accept a bytes object as a charset name. Of course if it is needed for Charset's __init__ the code should not be removed. -- ___ Python tracker ___

[issue18778] email docstrings and comments say about Unicode strings

R. David Murray added the comment: The comment, however, is clearly no longer appropriate :) -- ___ Python tracker ___ ___ Python-bugs

[issue18778] email docstrings and comments say about Unicode strings

R. David Murray added the comment: If you mean the code in Charset's __init__, if you change that you'll have backward compatibility issues. As the code currently stands it is legal to pass in a charset name that is bytes. And the string path of that if checks that it contains only ASCII cha

[issue18778] email docstrings and comments say about Unicode strings

New submission from Serhiy Storchaka: email docstrings and comments uses the "Unicode string" term and refer to the unicode() built-in. In 3.x this should be corrected to "string" and "str()". Perhaps some code (for example coercing a charset name to Unicode) is not needed more. -- co