[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-09-27 Thread Roundup Robot
Roundup Robot added the comment: New changeset b717128799b5 by R David Murray in branch '3.4': #18854: make it explicit that is_multipart does not mean 'multipart/xxx'. https://hg.python.org/cpython/rev/b717128799b5 New changeset 9909de463dc9 by R David Murray in branch 'default': Merge:

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-09-27 Thread R. David Murray
R. David Murray added the comment: Thanks Abhilash. I decided to use the full example after all, but tuned up the language a bit. -- resolution: - fixed stage: commit review - resolved status: open - closed type: - behavior versions: +Python 3.5 -Python 3.3

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-05-07 Thread Abhilash Raj
Abhilash Raj added the comment: I have tried to document the issue in the patch as discussed. David: Do you think I should also add an example in walk() method to demonstrate that it does not iterate over a 'message/rfc822' part even though it is multipart? -- keywords: +patch nosy:

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-05-07 Thread R. David Murray
R. David Murray added the comment: Take a look at the source for msg_16.txt. The last part is a message/rfc822, which encapsulates a text/plain message. So it *does* iterate over it, even though it isn't a 'multipart' type (the opposite of what you say in the doc patch). Explicitly

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-05-07 Thread Abhilash Raj
Abhilash Raj added the comment: Sorry, my bad. I was a little confused. I have updated the patch and also added the example explicitly. -- Added file: http://bugs.python.org/file35174/email-1.patch ___ Python tracker rep...@bugs.python.org

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-05-07 Thread R. David Murray
R. David Murray added the comment: Using _structure is a great idea. I'm not so fond of the full example, but I'll have to contemplate the text to decide what I'd rather do. Probably I'll take this patch of yours and tweak it, rather than try to tell you what I want :) Thanks for the

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-03-16 Thread Nitika Agarwal
Nitika Agarwal added the comment: Hi David, I didn't exactly get the issue.Will you please help me with what is to be updated. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18854 ___

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-03-16 Thread R. David Murray
R. David Murray added the comment: Well, probably the best thing to do to understand the issue is to look at the implementation of Message.walk and is_multipart, and to notice that is_multipart() can return a different answer than msg.get_content_maintype() == 'multipart' if the Message

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-03-15 Thread Nitika Agarwal
Nitika Agarwal added the comment: Hello everyone, I am working on this issue to create a patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18854 ___

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-03-12 Thread Nitika Agarwal
Nitika Agarwal added the comment: Hi David, Will you please help me with the link? -- nosy: +nitika ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18854 ___

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2014-03-12 Thread R. David Murray
R. David Murray added the comment: If you are asking which documentation needs to be updated, it is: Doc/library/email.message.rst The descriptions of the is_multipart method and the walk method. -- ___ Python tracker rep...@bugs.python.org

[issue18854] is_multipart and walk should document their treatment of 'message' parts.

2013-08-27 Thread R. David Murray
New submission from R. David Murray: A 'message' part is not, in fact, a multipart in RFC terms. (Only 'multipart' messages are multiparts.) The email package models 'message' parts by making them single-element multipart messages, with the single element being a Message object representing