[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: The last dependencies have now been closed! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Mark Lawrence added the comment: I've asked for patch reviewss on the three dependencies outstanding, #19711, #19714 and #21099. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Mark Lawrence added the comment: Given that PEP 451 is listed in the Finished PEPs (done, implemented in code repository) section of the PEP index can we close this and associated issues out? -- nosy: +BreamoreBoy ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Terry J. Reedy added the comment: Dependencies 19711 and 21099 are still open. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: -- dependencies: +Address remaining PEP 451-related to-do comments., Switch applicable importlib tests to use PEP 451 API ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: I've gone ahead and moved all remaining work into separate issues. Once the 4 remaining sub-issues are resolved, this one can be closed. I've *finally* got a couple days free so I want to close this out. :) -- ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Terry J. Reedy added the comment: Failure with 3.4.0c1: [170/394/5] test_importlib test test_importlib failed -- Traceback (most recent call last): File C:\Programs\Python34.32\lib\unittest\case.py, line 57, in testPartExecutor yield File C:\Programs\Python34.32\lib\unittest\case.py,

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: Terry has admitted in other bugs he filed that he didn't use a fresh install location, so the test failure is most likely a red herring. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: About the only thing left for this ticket is to finish up writing a few tests and round out some documentation. -- dependencies: -Update pickle to take advantage of PEP 451, Update zipimport for PEP 451 ___ Python

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: There are a few lingering to-do comments that will need to be addressed as part of the remaining work: Lib/test/test_importlib/extension/test_case_sensitivity.py:# XXX find_spec tests Lib/test/test_importlib/extension/test_finder.py:# XXX find_spec tests

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: -- dependencies: -Implement _imp.exec_builtin and exec_dynamic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: LGTM -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Roundup Robot added the comment: New changeset e961a166dc70 by Eric Snow in branch 'default': Issue #18864: Add a setter for ModuleSpec.has_location. http://hg.python.org/cpython/rev/e961a166dc70 -- ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Here's a patch for adding a setter for ModuleSpec.has_location. -- Added file: http://bugs.python.org/file33073/issue18864-has-location-setter.diff ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: Actually, ignore the __init__() part of my last comment since it's set to False directly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: (c) it is then! I would just take the time to call bool() on the arg to coalesce it into a True/False thing (which maybe makes sense in __init__() as well). -- ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: -haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Good catch. My preference would be for (c) simply add a setter for the property that sets the underlying private variable to True or False. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: I just realized that there is no way to make ModuleSpec.has_location return True if the spec is created by simply instantiating ModuleSpec. As it stands now you **must** go through importlib.util.spec_from_file_location(), which makes it not a helper but a

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Claudiu.Popa pcmantic...@gmail.com: -- nosy: +Claudiu.Popa ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +refactor pythonrun.c to make use of specs (__main__.__spec__) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Implement _imp.exec_builtin and exec_dynamic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

STINNER Victor added the comment: Your commit doesn't compile on Windows. CategoryNone Changed by Eric Snow ericsnowcurren...@gmail.com Changed at Fri 22 Nov 2013 16:17:09 Branch default Revision07229c6104b16d0ab7cc63f3306157d3d2819fed Comments Implement PEP 451

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: No longer blocking b1, now just blocking rc1. -- dependencies: +Update zipimport for PEP 451 priority: release blocker - deferred blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Update runpy for PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Update multiprocessing for PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Upate pydoc to PEP 451, Update pickle to PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Update test.test_threaded_import to PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Update test.test_namespace_pkgs to PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Check if inspect needs updating for PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Check if unittest.mock needs updating for PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Check pkgutil for anything missing for PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Check pythonrun.c is fully using PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +add test for changed portions after reloading a namespace package ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Deprecate various things in importlib thanks to PEP 451 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Make sure there are exec_module tests for _LoaderBasics subclasses ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Make sure documentation for PEP 451 is finished ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- dependencies: +Add tests for importlib.machinery.WindowsRegistryFinder ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Berker Peksag added the comment: There is a commented-out line in Lib/importlib/_bootstrap.py: +#if hasattr(loader, 'get_data'): +if hasattr(loader, 'get_filename'): http://hg.python.org/cpython/rev/07229c6104b1#l6.369 -- ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: Removed the commented-out line in c8a84eed9155 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Failing buildbot: http://buildbot.python.org/all/builders/x86%20XP-4%203.x/builds/9630/steps/test/logs/stdio test.test_module.ModuleTests.test_module_repr_source test.test_pkgutil.ExtendPathTests.test_iter_importers (passed when retried) --

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: Same failures on http://buildbot.python.org/all/builders/x86%20Gentoo%203.x/builds/5444/steps/test/logs/stdio -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: The test_module failure can be triggered by running test_importlib test_module. For some reason unittest's __spec__ gets set to one for the BuiltinImporter (and nothing else). -- ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Roundup Robot added the comment: New changeset 98bab4a03120 by Brett Cannon in branch 'default': Issue #18864: Don't try and use unittest as a testing module for http://hg.python.org/cpython/rev/98bab4a03120 -- nosy: +python-dev ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: Semantic-affecting changes first, then fluffy bits in terms of priority. Basically go based on what is most critical to be in 3.4. And yes, basically can you comment out find_module/find_loader/load_module and execute the test suite (sans import-related tests)

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: I've updated the TODO a little as well as cleaning up the XXX markers. The relevant ones are mostly just open questions on implementation tweaks, so nothing major. Otherwise my goal is to finish as much as possible of the non-critical items before the beta.

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: That's not the right fix for that test failure. If exec_module() is not meant to set import-related attributes like __cached__ because import itself (through _SpecMethods.init_module_attrs()) then test_frozen needs to be updated to not expect such attributes.

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: Just a heads up - since the two of you appear to have this well in hand, don't wait for a review from me before committing it. I have plenty of other things to look at before the beta deadline :) -- ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Brett: looks like something frozen-related broke due to 6d1656ab2c85a527c. test_frozen in test_frozen.py is failing now because frozen modules no longer have a __cached__ attribute (which was previously set to None). Previously it was set in

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: FYI, as of cc7ebd952777 the bulk of the implementation in features/pep-451 is working. There is a failing test on the Windows Server 2003 buildbot (which I'm trying to track down). I haven't been able to reproduce the failure on other buildbots, on my local

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Cool. Roundup linked the revision hash to the feature clone. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: The three Windows machines look like they have very different system versions of Python (ActiveState, cygwin, vanilla CPython). Any chance we're accidentally invoking the system Python instead of the built one somewhere? --

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: I think worrying about more API expansions to handle edge case/advanced reload scenarios is not worth it (or at least not in Python 3.4). And if we are shifting importlib.reload() back to looking for a new finder then we are only worrying about when people

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: The three Windows machines look like they have very different system versions of Python (ActiveState, cygwin, vanilla CPython). Any chance we're accidentally invoking the system Python instead of the built one somewhere? Good point. I'll check that out. That

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: I think worrying about more API expansions to handle edge case/advanced reload scenarios is not worth it (or at least not in Python 3.4). Agreed. -- ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Regarding the to-do list, I'm going to add a TODO file to the root of the feature clone (in the pep451 branch) so we don't have to keep updating this ticket. :) -- ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: 1. was intentionally left blank wink -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Sorry that wasn't more clear. I committed the changes from the modulespec-primary-changes.diff patch to the pep451 branch in the server-side clone. Those changes are: Step 1 -- 1. added ModuleSpec class 2. added _SpecMethods wrapper class 3. added ModuleSpec

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Regarding tests, a bunch of importlib (and other?) tests make direct calls to find_module(), find_loader(), or load_module(). These are still working, as expected. However, we should probably either replace them or supplement them with equivalent tests that make

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: Yeah, don't replace any tests, add new ones for the new APIs. Given the needs of 2/3 compatible loader implementations, the deprecations referred to in the PEP should also be documentation-only for 3.4. A more conservative approach also gives us a chance to make

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Yeah, don't replace any tests, add new ones for the new APIs. That's what makes the most sense to me too. Given the needs of 2/3 compatible loader implementations, the deprecations referred to in the PEP should also be documentation-only for 3.4. I'm fine with

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: Although, a boolean query method would bring back the problem of the loader not reporting any details on *why* it can't load into a particular target module. So it may be better to have an optional loader check_existing_target API that throws a suitable exception

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: On 12 Nov 2013 09:36, Eric Snow rep...@bugs.python.org wrote: As we found out (and you expounded) there are a variety of reload/load-into cases that we could address more explicitly. Perhaps there's a better API that could address those needs more broadly, or

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: (I still like the idea of passing a target to importlib.find_spec - I just no longer think we should be passing that down to the finders themselves). Passing the target to the finders isn't just for the sake of any implicit check_target test, though that was the

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: And coming full circle: there's no *harm* in letting finders reject loading into a target module, and that's orthogonal to having loaders reject it. It's just that loaders that want to do that will currently still need to implement load_module. That means the

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Sounds good. It will be worth adding a note to the load_module() docs indicating the limited cases where it is still appropriate, and encouraging the use of exec_module() instead. -- ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: I'm running the pep-451 clone against 2 buildbots for now: * http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%20custom * http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%20custom The ubuntu one is happy with the feature

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: The OS X buildbot I used [1] did not exhibit any of the failures that Windows server 2003 showed. [1] http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%20custom -- ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: The Windows 7 buildbot I tried [1] shows the exact same failures that the server 2003 does. [1] http://buildbot.python.org/all/builders/x86%20Windows7%20custom -- ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Naturally the other Windows buildbot I tried did not fail any import-related tests. So much for consistency. :( http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20custom -- ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: I don't quite know what you mean by current functional changes in the clone. Is this changes to import to use exec_module() and such? Just a guess since step 3 suggests there are no loaders implementing the new API currently. As for the tests, I'm hoping that

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: I should clarify why I want a clarification on step 1. On Friday my current plan (barring other bugs I need to squash for b1) is to just start working on the pep-451 repo and I want a TODO list to follow in this issue so I don't have to waste time trying to

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: I've created a server-side clone for the implementation: http://hg.python.org/features/pep-451/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Okay, I've updated the pep451 branch in the clone to include as much of the implementation as I've completed, which is the bulk of the functional changes. It's enough to pass the test suite. Here's what I'd like to get done before the feature freeze (in this

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Here's a new patch that is mostly up to date with the PEP. I still need to work on Docs and add more tests. There are a few failing tests (due to the recent reload patch) that I need to fix when I get a minute. This patch also implements find_spec() on

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file32408/modulespec-primary-changes.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: Added file: http://bugs.python.org/file32457/modulespec-primary-changes.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file32456/modulespec-primary-changes.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Here's an updated patch that implements the meat of the current PEP. Docs are still lacking and I could probably add a few more tests. Other key things left to do: * deprecations and removals * refactor importlib finders and loaders to use the new Finder/Loader

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file32407/modulespec-primary-changes.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: This time against tip. :) I should also point out that this patch is on top of the path in issue19413. -- Added file: http://bugs.python.org/file32408/modulespec-primary-changes.diff ___ Python tracker

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: Something else we may be able to fix (albeit probably not in 3.4): several of the issues noted in PEP 395 (since __main__.__spec__.name will give the real module name, even when __name__ is set to __main__ or otherwise modified) --

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Here's an update of the language reference patch based on Brett's comments. -- Added file: http://bugs.python.org/file32381/import-system-reference.diff ___ Python tracker rep...@bugs.python.org

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file32349/import-system-reference.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Here's a patch just for the changes to the import page in the language reference. It's not perfect, but should represent the target pretty closely. -- nosy: +ncoghlan Added file: http://bugs.python.org/file32348/import-system-reference.diff

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: Removed file: http://bugs.python.org/file32348/import-system-reference.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Let's try that again with the proper diff. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Eric Snow ericsnowcurren...@gmail.com: Added file: http://bugs.python.org/file32349/import-system-reference.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Nick Coghlan added the comment: Thanks, that looks pretty good - so much less work for loaders to do. After this, we may even be able to finally fix the circular import bug and the one where submodule imports succeed but the overall package import fails. --

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Brett Cannon added the comment: I've added a review -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list mailing list

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Eric Snow added the comment: Here's an initial patch. Some key things left to do: * unit tests * documentation * implement exec_module() for the various importlib loaders. Once that's squared away there are further things that will be addressed in new tickets (or at least separate patches).

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

New submission from Eric Snow: This ticket will track the implementation for PEP 451 (ModuleSpec). I'll have a patch up in the next couple days. -- assignee: eric.snow components: Interpreter Core, Library (Lib) messages: 196352 nosy: eric.snow priority: normal severity: normal stage:

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

Changes by Brett Cannon br...@python.org: -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18864 ___ ___ Python-bugs-list