Giampaolo Rodola' added the comment:
hg import http://bugs.python.org/file34522/devpoll3.patch; applies cleanly for
me. Not sure what else to do.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Changes by Charles-François Natali cf.nat...@gmail.com:
Added file: http://bugs.python.org/file34535/devpoll3_try_again.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
Guido van Rossum added the comment:
LGTM, but I don't have a Solaris box to test. I suppose one of you has tested
this? Then okay to commit to the default (== 3.5) branch.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 0a51a516bc70 by Giampaolo Rodola' in branch 'default':
Fix issue 18931: selectors module now supports /dev/poll on Solaris.
http://hg.python.org/cpython/rev/0a51a516bc70
--
___
Python tracker
Giampaolo Rodola' added the comment:
I successfully tested this on Solaris 11.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
components: +Library (Lib)
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Giampaolo Rodola' added the comment:
Regenerated without --git.
--
Added file: http://bugs.python.org/file34522/devpoll3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
Yury Selivanov added the comment:
Still no review link. Somehow you managed to upload the first patch correctly.
Does the new one apply cleanly on the default branch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Giampaolo Rodola' added the comment:
Patch in attachment.
--
Added file: http://bugs.python.org/file34494/devpoll2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
Charles-François Natali added the comment:
Could you regenerate it without --git (it doesn't show under the review
tool)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
Yury Selivanov added the comment:
Why there is no 'review' link for the new patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Guido van Rossum added the comment:
review links are only generated for patches that apply cleanly (I don't
know to which branch)
On Tue, Mar 18, 2014 at 2:37 PM, Yury Selivanov rep...@bugs.python.orgwrote:
Yury Selivanov added the comment:
Why there is no 'review' link for the new patch?
Jesús Cea Avión added the comment:
We missed 3.4 :-(.
Targeting Python 3.5 now. Giampaolo, could you possibly refresh your patch?.
Thanks.
--
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' added the comment:
Sorry for not being able to rewrite the patch in time for 3.4.
I will provide an updated patch (I need to setup an Open Solaris box first
though).
The code for poll(), epoll() and /dev/poll will have many similarities, so I
think it makes sense to refactor
Guido van Rossum added the comment:
I actually prefer some code duplication in this case. Makes the review
easier.
On Mar 17, 2014 2:17 PM, Giampaolo Rodola' rep...@bugs.python.org wrote:
Giampaolo Rodola' added the comment:
Sorry for not being able to rewrite the patch in time for 3.4.
I
Giampaolo Rodola' added the comment:
OK, I will provide a patch soon.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Jesús Cea Avión added the comment:
BDFL talked :-).
I can test the patch on a Solaris box, and Python has OpenSolaris buildbots.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
Changes by Yury Selivanov yselivanov...@gmail.com:
--
nosy: +yselivanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
STINNER Victor added the comment:
@Giampaolo: Your patch doesn't apply cleanly anymore. Could you update it?
Issue #19172 has been fixed, selectors now have a get_map() method.
--
___
Python tracker rep...@bugs.python.org
Charles-François Natali added the comment:
Just to let you know that I'm not forgetting this issue.
I'd just like to iron-out issue #19172 (keys()-like method for selectors),
since it could impact the API, to avoid repeated refactoring.
--
___
New submission from Giampaolo Rodola':
This is a follow up of issue 16853.
I will try to see whether I can come up with a patch later today.
--
messages: 196989
nosy: christian.heimes, felipecruz, giampaolo.rodola, gvanrossum, haypo,
meador.inge, neologix, pitrou, python-dev,
Giampaolo Rodola' added the comment:
Patch is in attachment.
--
keywords: +patch
Added file: http://bugs.python.org/file31618/devpoll.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Python-bugs-list mailing list
23 matches
Mail list logo
