Tim Peters added the comment:
Antoine, could I bother you to try the attached cleanup.patch? It looks
harmless to me, but when I checked it in the Unix-y buildbots failed the
thread+fork tests again :-( Two examples:
Antoine Pitrou added the comment:
I suppose we can close this issue now?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18984
___
___
Antoine Pitrou added the comment:
Here is a fixed patch (works here, at least :-)).
--
Added file: http://bugs.python.org/file31701/cleanup2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18984
Tim Peters added the comment:
Yes - and I just closed 18808 :-)
--
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18984
___
Tim Peters added the comment:
Well - I remain baffled, but am grateful for the patch - thanks :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18984
___
New submission from Tim Peters:
As discussed in issue 18808, now that we're checking for a tstate lock, the
Thread._stopped Event has become an attractive nuisance. The attached patch
removes it.
This simplifies .join() and .is_alive(), and restores pre-18808 .join(timeout)
endcase behavior
Changes by Tim Peters t...@python.org:
--
dependencies: +Thread.join returns before PyThreadState is destroyed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18984
___
Antoine Pitrou added the comment:
Hmm.. I'm getting the following failures:
==
FAIL: test_4_joining_across_fork_in_worker_thread
(test.test_threading.ThreadJoinOnShutdown)
Antoine Pitrou added the comment:
Looks like it's mostly the tests trying to check an implementation detail that
doesn't exist anymore :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18984
Tim Peters added the comment:
I agree with your diagnosis. Unfortunately, I can't test the fork stuff.
Well, OK, I actually think that's fortunate (for me ;-) ).
If you can see a quick way to fix these, please do. I'm going to vanish for
about 2 hours now.
--
Antoine Pitrou added the comment:
I think the fix is simply to remove the outdated tests.
I've been running test_threading in a loop with the (attached) updated patch,
and there hasn't been a single failure.
--
type: - resource usage
Added file:
Roundup Robot added the comment:
New changeset aff959a3ba13 by Tim Peters in branch 'default':
Issue 18984: Remove ._stopped Event from Thread internals.
http://hg.python.org/cpython/rev/aff959a3ba13
--
nosy: +python-dev
___
Python tracker
Tim Peters added the comment:
Thanks, Antoine! I pushed this change, figuring that even if some buildbots
are still unhappy about 18808, getting rid of the Event can't make them more
unhappy, and may make them happier.
--
resolution: - fixed
___
Changes by Tim Peters t...@python.org:
--
Removed message: http://bugs.python.org/msg197342
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18984
___
Tim Peters added the comment:
New changeset aff959a3ba13 by Tim Peters in branch 'default':
Issue 18984: Remove ._stopped Event from Thread internals.
http://hg.python.org/cpython/rev/aff959a3ba13
--
___
Python tracker rep...@bugs.python.org
15 matches
Mail list logo
