[issue19119] duplicate test name in Lib/test/test_heapq.py

Raymond Hettinger added the comment: Removed the bogus test -- it was a cut-and-paste error from a scratch file. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue19119] duplicate test name in Lib/test/test_heapq.py

Raymond Hettinger added the comment: New changeset ef3ccd737020a0bb49ea0bfe48069f89bb5370a1 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-19119: Remove invalid test and rename a misnamed test (GH-15442) (GH-15447)

[issue19119] duplicate test name in Lib/test/test_heapq.py

Change by miss-islington : -- pull_requests: +15139 pull_request: https://github.com/python/cpython/pull/15447 ___ Python tracker ___

[issue19119] duplicate test name in Lib/test/test_heapq.py

Raymond Hettinger added the comment: New changeset 4101181fd87c2fab6456663d3c8cc99377cf0463 by Raymond Hettinger in branch 'master': bpo-19119: Remove invalid test and rename a misnamed test (GH-15442) https://github.com/python/cpython/commit/4101181fd87c2fab6456663d3c8cc99377cf0463

[issue19119] duplicate test name in Lib/test/test_heapq.py

Change by Raymond Hettinger : -- pull_requests: +15135 pull_request: https://github.com/python/cpython/pull/15442 ___ Python tracker ___

[issue19119] duplicate test name in Lib/test/test_heapq.py

Change by Xavier de Gaye : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19119] duplicate test name in Lib/test/test_heapq.py

Change by Xavier de Gaye : -- versions: +Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19119] duplicate test name in Lib/test/test_heapq.py

Ben Roberts added the comment: Any thoughts/reviews on the patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19119 ___ ___ Python-bugs-list

[issue19119] duplicate test name in Lib/test/test_heapq.py

Berker Peksag added the comment: In the 2.7 branch, the test was removed in issue 7871 (changeset https://hg.python.org/cpython/rev/0130e574f5be). -- components: +Tests -Library (Lib) nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org

[issue19119] duplicate test name in Lib/test/test_heapq.py

Ben Roberts added the comment: That is one approach, of course, but imo pretty incomplete. A test that is named test_get_only presumably would be expected to test __getitem__, not __cmp__. Confusingly there is still a GetOnly item declared in the module, but it is not used. Compare to

[issue19119] duplicate test name in Lib/test/test_heapq.py

Changes by Berker Peksag berker.pek...@gmail.com: -- stage: - patch review versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19119 ___

[issue19119] duplicate test name in Lib/test/test_heapq.py

Ben Roberts added the comment: The major issue (there are other issues as well but not so difficult) is whether nlargest and nsmallest should support iterator that could be endless iterator or reject it (by checking __len__ attribute) straight away. Well, failing with an exception isn't

[issue19119] duplicate test name in Lib/test/test_heapq.py

Ben Roberts added the comment: Attached patch fixes the tests. -- Added file: http://bugs.python.org/file36683/fix_heapq_tests.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19119 ___

[issue19119] duplicate test name in Lib/test/test_heapq.py

Vajrasky Kok added the comment: I have played around with this test. The major issue (there are other issues as well but not so difficult) is whether nlargest and nsmallest should support iterator that could be endless iterator or reject it (by checking __len__ attribute) straight away. Once

[issue19119] duplicate test name in Lib/test/test_heapq.py

STINNER Victor added the comment: @Xavier de Gaye: Nice, you found many similar issues. How did you find them? Would it be possible to automate the detection of duplicated test names? -- nosy: +haypo ___ Python tracker rep...@bugs.python.org

[issue19119] duplicate test name in Lib/test/test_heapq.py

Xavier de Gaye added the comment: It was proposed, in issue 16056, to enhance `make patchcheck` with the detection of duplicate code names. This triggered the creation of issue 16079. The script named duplicate_code_names_2.py, in issue 16079, listed about 20 duplicate names among all the

[issue19119] duplicate test name in Lib/test/test_heapq.py

Changes by STINNER Victor victor.stin...@gmail.com: -- versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19119 ___ ___

[issue19119] duplicate test name in Lib/test/test_heapq.py

Tim Peters added the comment: Good catch! Would like to hear from Raymond what the intent of these tests was - looks like the real test_get_only (which hasn't been executing) has multiple failures. -- nosy: +tim.peters ___ Python tracker

[issue19119] duplicate test name in Lib/test/test_heapq.py

Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- assignee: - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19119 ___ ___

[issue19119] duplicate test name in Lib/test/test_heapq.py

New submission from Xavier de Gaye: There are two test_get_only methods. The patch provides a partial fix, but removes the following two lines from the first method as the execution of these lines fails: for f in (self.module.nlargest, self.module.nsmallest):