[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Aside from the default-install -> default-pip name change, the other fixes/changes between Donald's last patch and the committed version: - added the missing docs for the new options - updated What's New, ACKS, NEWS - avoided repetition in the test code by using

[issue19406] PEP 453: add the ensurepip module

Roundup Robot added the comment: New changeset 6a6b1ee306e3 by Nick Coghlan in branch 'default': Close #19406: Initial implementation of ensurepip http://hg.python.org/cpython/rev/6a6b1ee306e3 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> closed

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: The inconsistency between altinstall and default_install bothered me, so I plan to change the spelling of the latter option to "default_pip" (since it directly controls whether or not the "pip" script gets installed). --

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: I'm also going to start creating the implementation issues for the installer and pyvenv updates. -- ___ Python tracker ___ __

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Assigning to myself for final review and commit :) -- assignee: dstufft -> ncoghlan ___ Python tracker ___ ___

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: * Updated setuptools * Updated pip to the latest development snapshot * Installs default to installing easy_install-X.Y, pipX, and pipX.Y * Added --altinstall which only installs easy_install-X.Y and pipX.Y * Added --default-install which installs easy_install, ea

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Donald, I know you've been busy with PyPI v2.0 the last few days, but I see the pull request to resolve https://github.com/pypa/pip/issues/1294 has been merged. If we can get an updated patch that sets ENSUREPIP_OPTIONS appropriately in the process environment,

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: I'm OK with an unqualified "pip install --upgrade pip" retaining pip's current behaviour of always writing the unqualified script versions. However, running "pip3 install --upgrade pip" would ideally leave the "pip" and "easy_install" scripts alone. For "make a

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Tweaking the Wheels won't work. The scripts are generated at install time. We need to fix it in pip, I was waiting on answers to http://bugs.python.org/issue19406#msg201954 before coming up with a solution and making a PR request as that will influence the prop

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: I created https://github.com/pypa/pip/issues/1294 for the script versioning issue on the pip side, as I'd prefer not to be doing the temporary directory dance if we don't need to. How do we want to handle this for beta 1? Is it OK to do an initial commit that h

[issue19406] PEP 453: add the ensurepip module

Ned Deily added the comment: Without digging deeper, I'd be a little cautious about using a test involving sys.executable and shutil.which. sys.executable in the past at least was not always what you might think in certain cases with OS X framework installs. -- __

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: The "install everything" approach is OK for Windows and virtual environments. The challenge is the shared bin directories on *nix systems. Perhaps pip itself could be updated such that it installs the bare "pip" only if sys.executable matches shutil.which("python"

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Attached is the second combined2 patch with Ned's feedback incorporated. For anyone testing this the patch does not contain the binary files which can be found at https://github.com/dstufft/cpython/blob/ensurepip/Lib/ensurepip/_bundled/. -- Added file:

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Oh nevermind, I understand now. I misread the statement. I can do that. -- ___ Python tracker ___ ___

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Oh one thing, I can't move anything out of _run_pip because the part you're referring to is actually modifying the sys.path. If I move it then I can't prevent the tests from having side effects. -- ___ Python tracker

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: The .pya thing is an experimental extension type that setuptools added that just got missed during the new features to generate scripts during wheel install vs wheel build time. I opened a bug to remove that and it'll be gone before 1.5 is released. I can fix

[issue19406] PEP 453: add the ensurepip module

Ned Deily added the comment: Just for the record, here's what the installed ./lib/python3.4/site-packages looks like after ensurepip has run: -rw-r--r-- 1 nad pyd 119 Nov 1 15:20 README drwxr-x--- 2 nad pyd 204 Nov 1 15:21 __pycache__/ drwxr-x--- 3 nad pyd 170 Nov 1 1

[issue19406] PEP 453: add the ensurepip module

Ned Deily added the comment: I suppose the changes could be isolated to just ensurepip if it used a temporary dir for the scripts and then moved the appropriate ones itself to the standard scripts directory. -- ___ Python tracker

[issue19406] PEP 453: add the ensurepip module

Ned Deily added the comment: Here are my review comments (sorry, no Rietveld): ensurepip/__init__.py - Why have the separate _run_pip function? It would be simpler and less confusing to just merge run_pip into bootstrap and eliminate the extra for loop. Both depend on th

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: There you go Nick. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue19406] PEP 453: add the ensurepip module

Changes by Donald Stufft : Added file: http://bugs.python.org/file32446/combined.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Donald, could you upload an updated patch here that includes both your changes and my docs updates? We'll give people a day to look it over, and then go ahead and commit it and create the tracker issues to update pyvenv/venv and the Mac OS X and Windows install

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Ok, merged in the --root fix to pip and created a Wheel using Python 3.4 (which I installed the Wheel distribution using an ensurepip installed pip ;) ). Updated on github and a patch added, all outstanding issues that affect this patch exist on the pip side of

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: I also need to update the bundled Wheel to one that was created with Python 3.4 instead of 2.7 (which matters until the fix for https://github.com/pypa/pip/issues/1067 which is https://github.com/pypa/pip/pull/1251 lands). That fixes the issue where the wheel

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: For what it's worth I can get --root ready to go shortly, I have a patch against pip for it (https://github.com/pypa/pip/pull/1272) I just need to write some tests to ensure it keeps working. Let me go off and do that right now. --

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Added most of the nosy list from the tracking issue 19347. Updated draft docs. I believe this version of the module docs should be complete (since the installation guide updates are covered by issue 19407). While Donald's attached patch is incomplete, the versio

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: You cannot use --user in a virtual environment (well a venv, no idea about a pyvenv - but it should get a similar error message IMO if it doesn't). If you use --root and --user together it will install to the --root location, using the user layout, so instead o

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Draft docs patch attached. This splits out a new "Software Packaging and Distribution" section in the main docs index, with distutils, ensurepip and venv as the specific entries. There's a couple of questions I need answered regarding the behaviour of pip in or

[issue19406] PEP 453: add the ensurepip module

Changes by Donald Stufft : Removed file: http://bugs.python.org/file32373/draft2.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19406] PEP 453: add the ensurepip module

Changes by Donald Stufft : Removed file: http://bugs.python.org/file32371/draft.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Added a third draft, this one adds the script to check if pip needs updated. I've removed the first two drafts to make it simpler. -- Added file: http://bugs.python.org/file32374/draft3.diff ___ Python tracker

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Added a second draft that handles the case when the stdlib isn't directly browseable (e.g. it's zipped up or something). -- Added file: http://bugs.python.org/file32373/draft2.diff ___ Python tracker

[issue19406] PEP 453: add the ensurepip module

Donald Stufft added the comment: Attached is an initial rough draft of the ensurepip module. There are some issues still, but they largely need resolved in pip. 1. Setuptools' use of dependency_links causes pip to still reach out to the internet. 2. Need to remove the --pre flag from the pip i

[issue19406] PEP 453: add the ensurepip module

Changes by Nick Coghlan : -- Removed message: http://bugs.python.org/msg201347 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Issue 19347 tracks overall PEP 453 implementation progress -- ___ Python tracker ___ ___ Python-bugs-l

[issue19406] PEP 453: add the ensurepip module

Nick Coghlan added the comment: Issue 19437 tracks overall PEP 453 implementation progress -- ___ Python tracker ___ ___ Python-bugs-l

[issue19406] PEP 453: add the ensurepip module

New submission from Nick Coghlan: Adding the initial ensurepip implementation and module docs (the "Installing Python Modules" updates will be handled in a separate issue) -- assignee: dstufft components: Library (Lib) messages: 201342 nosy: dstufft, larry, ncoghlan priority: release bl