[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Change by Jakub Kulik : -- versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.7, Python 3.3 ___ Python tracker ___ ___

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Change by Jakub Kulik : -- pull_requests: +22106 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23208 ___ Python tracker ___

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Jakub Kulik added the comment: And for the reference, Solaris distros are already removing this code: https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Jakub Kulik added the comment: I think this code should be removed. It was added in its current form more than 20 years ago with the intention to add function declarations missing from system include files: https://github.com/python/cpython/commit/1e0c2f4bee43728930bd5f4dc77283f09c4ba004

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

John Beck added the comment: We (Solaris engineering) have hit this issue after migrating from 2.6 being our default version of Python to 2.7 being the default. The specific component that broke was vim (version 7.4), trying to compile if_python.c: /usr/include/python2.7/pyport.h, line 645:

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Changes by Thomas Klausner t...@giga.or.at: -- nosy: +wiz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19561 ___ ___ Python-bugs-list mailing

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Roundup Robot added the comment: New changeset 9ae1707d427a by R David Murray in branch 'default': whatsnew: summary section tweaks. http://hg.python.org/cpython/rev/9ae1707d427a -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Changes by R. David Murray rdmur...@bitdance.com: -- Removed message: http://bugs.python.org/msg213157 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19561 ___

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

New submission from Richard PALO: I'd like to have reopened this previous issue as it is still very much the case. I believe as well that the common distros (I can easily verify OpenIndiana and OmniOS) patch it out (patch file attached). Upstream/oracle/userland-gate seems to as well. It is

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

R. David Murray added the comment: We have an OpenIndian buildbot that compiles from our source, so no distro changes. Can you sort out why this isn't a problem on the buildbut but is for you? Your patch files says 2.6, so is it possible it is fixed in 2.7? -- nosy: +r.david.murray

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Richard PALO added the comment: I don't believe the problem is a question solely of building the python sources, but also certain dependent application sources... I know of at least libreoffice building against python and this problem has come up. The workaround was to apply the patch

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

R. David Murray added the comment: Libreoffice is a big thing to compile as a test...do you know of any smaller packages that exhibit the bug? I've added jcea to nosy, he set up the OpenIndiana buildbots and may be able to help clarify the issue. I'm not willing to opine on it since I don't

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Changes by R. David Murray rdmur...@bitdance.com: -- assignee: jcea - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19561 ___ ___

[issue19561] request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined

Richard PALO added the comment: Sure, attached is a simple test found on the internet, compiled with the following reproduces the problem: richard@devzone:~/src$ /opt/local/gcc48/bin/g++ -o tp tp.cpp -DSOLARIS -I/opt/local/include/python2.7 -L/opt/local/lib -lpython2.7 In file included from