Serhiy Storchaka added the comment:
Try to regenerate the patch for Rietveld.
--
Added file: http://bugs.python.org/file32667/test_descr_asserts_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19603
Ezio Melotti added the comment:
New patch LGTM.
In addition to the assertHasNoAttr that I suggested, on IRC David suggested
assertNotHasAttr to mimic assertNotIn and assertNotIsinstance, and someone else
suggested assertNoAttr.
Since it's only used within this file and all the suggestions are
Roundup Robot added the comment:
New changeset 2407ecebcf7d by Serhiy Storchaka in branch '3.3':
Issue #19603: Use specific asserts in test_decr.
http://hg.python.org/cpython/rev/2407ecebcf7d
New changeset 6049c954a703 by Serhiy Storchaka in branch 'default':
Issue #19603: Use specific asserts
Serhiy Storchaka added the comment:
Mimicing assertNotIsinstance looks fine. Thank you for your review.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file32658/test_descr_asserts.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19603
Ezio Melotti added the comment:
I left a few comments on rietveld.
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19603
___
Serhiy Storchaka added the comment:
Updated patch addresses Ezio's comments.
--
Added file: http://bugs.python.org/file32660/test_descr_asserts_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19603
New submission from Serhiy Storchaka:
The proposed patch makes test_descr use more specific asserts. This will
provide more useful failure report.
This is the largest patch in the series.
--
components: Tests
messages: 202925
nosy: serhiy.storchaka
priority: normal
severity: normal
