Roundup Robot added the comment:
New changeset fef075ddaec9 by Antoine Pitrou in branch 'default':
Issue #19648: implement empty tests in pickletester. Patch by Gennadiy Zlobin.
http://hg.python.org/cpython/rev/fef075ddaec9
--
nosy: +python-dev
___
Antoine Pitrou added the comment:
I've pushed the patch. Thank you for your contribution!
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
Gennadiy Zlobin added the comment:
Antoine, sure! I have just signed it. Thank you!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19648
___
___
Changes by Antoine Pitrou pit...@free.fr:
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19648
___
___
Antoine Pitrou added the comment:
The patch looks fine to me. Gennadiy, could you go and sign a contributor's
agreement? http://www.python.org/psf/contrib/
Thanks very much.
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
The patch looks good to me, but I can't claim to know enough about pickle to
say whether the tests are correct. Alexandre or Antoine?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19648
Gennadiy Zlobin added the comment:
Hi,
I created 2 simple tests for test_getinitargs and test_reduce.
--
keywords: +patch
nosy: +gennad
Added file: http://bugs.python.org/file33154/19648.patch
___
Python tracker rep...@bugs.python.org
New submission from Zachary Ware:
There are a couple of tests in pickletester that should either be implemented
or removed, namely test_reduce and test_getinitargs of AbstractPickleTests.
I don't know enough about pickling to suggest which route should be taken or
how, so I'll leave that up
