[issue19698] Implement _imp.exec_builtin and exec_dynamic

Brett Cannon added the comment: New changeset 2929bfb973da249ed4f056c88a69bcc48e5a4843 by Miss Islington (bot) in branch '3.7': bpo-19698: Document when importlib.machinery.FrozenImporter gained spec-related methods (GH-19158) (GH-19165)

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Brett Cannon added the comment: New changeset 8dad09a2242194a4101374b91ce87bb47a487cf7 by Miss Islington (bot) in branch '3.8': bpo-19698: Document when importlib.machinery.FrozenImporter gained spec-related methods (GH-19158) (#19164)

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Change by Brett Cannon : -- keywords: -patch resolution: -> fixed stage: patch review -> needs patch status: open -> closed ___ Python tracker ___

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Change by miss-islington : -- pull_requests: +18525 pull_request: https://github.com/python/cpython/pull/19165 ___ Python tracker ___

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Brett Cannon added the comment: New changeset 302e5a8f79514fd84bafbc44b7c97ec636302322 by Brett Cannon in branch 'master': bpo-19698: Document when importlib.machinery.FrozenImporter gained spec-related methods (GH-19158)

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +18524 pull_request: https://github.com/python/cpython/pull/19164 ___ Python tracker

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Change by Brett Cannon : -- keywords: +patch pull_requests: +18518 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19158 ___ Python tracker

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Change by Brett Cannon : -- assignee: docs@python -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Brett Cannon added the comment: At this point both FrozenImporter and BuiltinImporter support exec_module(), so the only thing left to do is to document when FrozenImporter and WindowsRegistryFinder gained their exec_module() implementations (BuiltinImporter already has a note about it).

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Nick Coghlan added the comment: Turns out I had written up a recap of the PEP 451 C extension support status back in July, so I just resent that to import-sig. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19698

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Eric Snow added the comment: Same here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19698 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Nick Coghlan added the comment: Yes, if we don't get to it beforehand. I'd still like to take the draft Create/Exec C level hook design I came up with and turn it into a PEP, but I don't know when I'll get time. Maybe I should just put that together as a (very) rough draft and lob it at

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Brett Cannon added the comment: sgtm -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19698 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Brett Cannon added the comment: I would still like to get this solved for Python 3.5. Should we hash out a solution at PyCon? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19698 ___

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Nick Coghlan added the comment: There are assorted shenanigans in the dynamic module loading code that make me think we should leave the associated loaders alone for now. Running PyInit_* more than once isn't permitted by default, so reloading is a no-op, and loading again *copies* the existing

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Eric Snow added the comment: Is the problem here that builtins (and extension modules) don't necessarily obey the rules to the letter? load_module() is supposed to use whatever is in sys.modules. [1] (BuiltinImporter.load_module() is essentially a synonym for _imp.init_builtin(), right?)

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Brett Cannon added the comment: This is going to have to wait until Python 3.5, so I'm going to back out the exec_module() aspects of BuiltinImporter and ExtensionFileLoader. As Nick has pointed out previously, we are going to need to change the init function signature of extension modules to

[issue19698] Implement _imp.exec_builtin and exec_dynamic

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19698 ___

[issue19698] Implement _imp.exec_builtin and exec_dynamic

New submission from Brett Cannon: Since _imp.init_builtin and _imp.load_dynamic don't take in a module to load, need to create new functions which do. Afterwards can deprecate init_builtin, load_dynamic, and init_frozen (the latter having been worked around thanks to get_frozen_object).