[issue19756] test_nntplib: sporadic failures, network isses? server down?

Change by Chris Jerdonek : -- nosy: -chris.jerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Chris Jerdonek added the comment: See also: https://bugs.python.org/issue40735 (test_with_statement) -- nosy: +chris.jerdonek ___ Python tracker ___

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: PR 9461 converts Martin's nntp-server.patch. I've made some tweaks and fixed a "threading._dangling was modified by test_nntplib" warning. I will try to convert multi-connect.patch later. I will attribute Martin as the patch author before merging the PR.

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Change by Berker Peksag : -- pull_requests: +8875 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: Thanks for the reviews, Victor. I'm planning to work on them tonight. I will close this issue and open a new one if I decide to do further work on them. -- ___ Python tracker

[issue19756] test_nntplib: sporadic failures, network isses? server down?

STINNER Victor added the comment: Thanks Berker! Do you want to do something with Martin's patches? If not, can you please close the issue? -- ___ Python tracker ___

[issue19756] test_nntplib: sporadic failures, network isses? server down?

miss-islington added the comment: New changeset 170ea8ccd4235d28538ab713041502d07ad1cacd by Miss Islington (bot) in branch '2.7': bpo-19756: Prevent test failures due to EADDRNOTAVAIL (GH-9446) https://github.com/python/cpython/commit/170ea8ccd4235d28538ab713041502d07ad1cacd --

[issue19756] test_nntplib: sporadic failures, network isses? server down?

miss-islington added the comment: New changeset 1eabe19c57938dd70b66b97239be337294e15cba by Miss Islington (bot) in branch '3.6': bpo-19756: Prevent test failures due to EADDRNOTAVAIL (GH-9446) https://github.com/python/cpython/commit/1eabe19c57938dd70b66b97239be337294e15cba --

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Change by miss-islington : -- pull_requests: +8865 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: New changeset 476177005e8c8d4ece3070c8c378f8b8c068e76f by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-19756: Prevent test failures due to EADDRNOTAVAIL (GH-9446) https://github.com/python/cpython/commit/476177005e8c8d4ece3070c8c378f8b8c068e76f

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: New changeset 8213eaddf3ce8e87564d2949454903a1484748b5 by Berker Peksag in branch 'master': bpo-19756: Prevent test failures due to EADDRNOTAVAIL (GH-9446) https://github.com/python/cpython/commit/8213eaddf3ce8e87564d2949454903a1484748b5 --

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Change by miss-islington : -- pull_requests: +8863 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Change by miss-islington : -- pull_requests: +8862 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Change by Berker Peksag : -- pull_requests: +8861 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: Yeah, I will submit a pull request today. The reason I reopened this issue is that I didn't want to file another issue for a similar problem and wanted to use this as a meta issue for issues with test_nntplib. Also, I'd like to play Martin's patches a bit

[issue19756] test_nntplib: sporadic failures, network isses? server down?

STINNER Victor added the comment: > Sure, that sounds like a reasonable change? Oh, typo: you should read "Sure, that sounds like a reasonable change." :-) -- ___ Python tracker

[issue19756] test_nntplib: sporadic failures, network isses? server down?

STINNER Victor added the comment: > I think it would be nice if tweaked support.transient_internet() to catch > EADDRNOTAVAIL. Sure, that sounds like a reasonable change? Do you want to work on a PR? If not, maybe we should open a new issue, since this issue is tidly linked to

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: I think it would be nice if tweaked support.transient_internet() to catch EADDRNOTAVAIL. See https://github.com/python/cpython/commit/e4dcbbd7f4ac18d01c0ec85f64ae98b8281ed403#diff-7fa374913c0ecbdc621db8ea79a1212bR78 for another example. --

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Change by Berker Peksag : -- Removed message: https://bugs.python.org/msg325858 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: == ERROR: setUpClass (test.test_nntplib.NetworkedNNTPTests) -- Traceback (most recent call last): File

[issue19756] test_nntplib: sporadic failures, network isses? server down?

STINNER Victor added the comment: I didn't see test_nntplib failing recently, so I close the issue as outdated. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue19756] test_nntplib: sporadic failures, network isses? server down?

STINNER Victor added the comment: Any progress on this issue? Martin: Can you please convert your latest patch into a Pull Request? -- ___ Python tracker

[issue19756] test_nntplib: sporadic failures, network isses? server down?

STINNER Victor added the comment: > ERROR: setUpClass (test.test_nntplib.NetworkedNNTP_SSLTests) I wrote an obvious fix for this one: issue #30188. -- ___ Python tracker

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Martin Panter added the comment: Multi-connect.patch is a smaller patch that changes setUpClass() → setUp(), so that each test method creates a new NNTP connection. The downside is all the reconnecting slows the test execution from 42 s down to 115 s, which is why I would like to move the

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Martin Panter added the comment: Here is a diff that shows my changes better. I temporarily moved some classes back to their original positions to reduce the diff size, though it won’t work in practice because Python needs the classes defined before using them. -- Added file:

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Changes by Berker Peksag : -- stage: needs patch -> patch review ___ Python tracker ___

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Martin Panter added the comment: Here is a patch that changes all affected tests to use a custom server running on localhost: * Local server is based on the existing NNTPv2Handler class, and the LocalServerTests class * Reintegrate test_starttls() back into NetworkedNNTPTestsMixin * Only

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Martin Panter added the comment: Thanks Berker. In this case the previous tests using the same NNTP connection object were skipped. First run: test_unknown_command (test.test_nntplib.NetworkedNNTPTests) ... ok test_welcome (test.test_nntplib.NetworkedNNTPTests) ... ok test_with_statement

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: I just saw the same test failures at http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.5/builds/998/steps/test/logs/stdio I'm attaching the test logs for future reference. -- nosy: +berker.peksag stage: -> needs patch type: ->

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Martin Panter added the comment: See Issue 1186900 about the NNTP client raising EOFError. As for the “cannot read from timed out object” errors (also reported in Issue 19613), I think the test classes are bad. The test logs don’t seem to be available, but I reckon that the previous test to

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Mark Lawrence added the comment: Are these sporadic failures still happening? I've glanced over the logs and only found failures due to recent code changes. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org

[issue19756] test_nntplib: sporadic failures, network isses? server down?

New submission from STINNER Victor: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.x/builds/692/steps/test/logs/stdio == ERROR: test_capabilities (test.test_nntplib.NetworkedNNTP_SSLTests)

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Antoine Pitrou added the comment: The third-party server isn't extremely reliable indeed. Ideally, we would run our own NNTP server, but that's a lot more work. -- nosy: +pitrou versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org