[issue19775] Provide samefile() on Path objects

Changes by Antoine Pitrou : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs

[issue19775] Provide samefile() on Path objects

Roundup Robot added the comment: New changeset 197ac5d79456 by Antoine Pitrou in branch 'default': Issue #19775: Add a samefile() method to pathlib Path objects. http://hg.python.org/cpython/rev/197ac5d79456 -- nosy: +python-dev ___ Python tracker

[issue19775] Provide samefile() on Path objects

Antoine Pitrou added the comment: Sorry, it seems I have let this issue slip. I will update the patch and commit it soon! -- ___ Python tracker ___ _

[issue19775] Provide samefile() on Path objects

Changes by Vajrasky Kok : Added file: http://bugs.python.org/file32979/pathlib_samefile_v3.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue19775] Provide samefile() on Path objects

Changes by Vajrasky Kok : Removed file: http://bugs.python.org/file32978/pathlib_samefile_v3.patch ___ Python tracker ___ ___ Python-bugs-list

[issue19775] Provide samefile() on Path objects

Changes by Vajrasky Kok : Added file: http://bugs.python.org/file32978/pathlib_samefile_v3.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue19775] Provide samefile() on Path objects

Changes by Vajrasky Kok : Removed file: http://bugs.python.org/file32977/pathlib_samefile_v3.patch ___ Python tracker ___ ___ Python-bugs-list

[issue19775] Provide samefile() on Path objects

Vajrasky Kok added the comment: Thanks for the review! Attached the patch addressing the request by Antoine. -- Added file: http://bugs.python.org/file32977/pathlib_samefile_v3.patch ___ Python tracker ___

[issue19775] Provide samefile() on Path objects

Antoine Pitrou added the comment: Thanks for the patch! Some comments: 1. It should path objects as well as str objects. 2. I don't think you have to call resolve() here. 3. you should probably test what happens when one of the files doesn't exist 4. you need to update the documentation too ---

[issue19775] Provide samefile() on Path objects

Vajrasky Kok added the comment: Updated grammar according to Arfrever's review. Thanks! Anyway, should samefile accepts only string? Or should it accept Path object as well? -- Added file: http://bugs.python.org/file32927/pathlib_samefile_v2.patch _

[issue19775] Provide samefile() on Path objects

Arfrever Frehtes Taifersar Arahesis added the comment: About doc string in patch: 1. s/same/the same/ 2. "same" is usually used with "as", not "with": https://books.google.com/ngrams/graph?content=same+as%2Csame+with%2Csame+to&year_start=1800&year_end=2000&corpus=15&smoothing=3 -- _

[issue19775] Provide samefile() on Path objects

Vajrasky Kok added the comment: Here is the patch. -- keywords: +patch nosy: +vajrasky Added file: http://bugs.python.org/file32916/pathlib_samefile.patch ___ Python tracker ___

[issue19775] Provide samefile() on Path objects

STINNER Victor added the comment: I like the idea :-) -- nosy: +gvanrossum, haypo ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19775] Provide samefile() on Path objects

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19775] Provide samefile() on Path objects

New submission from Antoine Pitrou: It would probably be useful to provide samefile() on Path objects - basically doing the same thing as os.path.samefile(). -- components: Library (Lib) messages: 204386 nosy: pitrou priority: normal severity: normal status: open title: Provide samefile