Eli Bendersky added the comment:
Committed in 90b56ec318b6
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
versions: +Python 3.2 -Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
Eli Bendersky added the comment:
Attaching a new patch. Hopefully the image will be viewable in the code review
tool
--
Added file: http://bugs.python.org/file32869/issue19799.2.patch
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Hopefully the image will be viewable in the code review tool
Apparently not :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
___
Eli Bendersky added the comment:
Just in case it isn't:
https://dl.dropboxusercontent.com/u/15602400/images/pathlib-inheritance.png
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
STINNER Victor added the comment:
Could you please attach the picture separatly?
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
___
Eli Bendersky added the comment:
On Wed, Nov 27, 2013 at 6:21 AM, STINNER Victor rep...@bugs.python.orgwrote:
STINNER Victor added the comment:
Could you please attach the picture separatly?
Done
--
___
Python tracker rep...@bugs.python.org
Changes by Eli Bendersky eli...@gmail.com:
Added file: http://bugs.python.org/file32871/pathlib-inheritance.png
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
___
STINNER Victor added the comment:
Which tool did you use to draw this schema? You may attach also the source if
someone would like to modify it in the future.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
Eli Bendersky added the comment:
STINNER Victor added the comment:
Which tool did you use to draw this schema? You may attach also the source
if someone would like to modify it in the future.
Sorry, but there's no source. I drew it graphically. But since I did it
with Google Drive's
STINNER Victor added the comment:
You can export the schema as SVG.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
___
___
New submission from Eli Bendersky:
Following up from Issue #19673; The initial patch clarifies the use cases of
pure vs. concrete paths a bit and adds explicit signatures for the path class
constructors (moving the construction discussion under the parent class).
Also, IMHO an inheritance
Changes by Eli Bendersky eli...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file32858/issue19799.initial.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
___
Antoine Pitrou added the comment:
Would you mind if I add a .png for the pathlib rst doc?
No, it sounds ok to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19799
___
13 matches
Mail list logo
