[issue20021] "modernize" makeopcodetargets.py

Serhiy Storchaka added the comment: Thank you Victor. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue20021] "modernize" makeopcodetargets.py

STINNER Victor added the comment: > Or does it matter to be able to use an external python program? Oh wait, I misunderstood how the script is used. I understood that the script must be run manually only when a new opcode is added and so is rarely used and only used with the built Python

[issue20021] "modernize" makeopcodetargets.py

Roundup Robot added the comment: New changeset 6ceceb052394 by Victor Stinner in branch 'default': makeopcodetargets.py: we need to import Lib/opcode.py https://hg.python.org/cpython/rev/6ceceb052394 -- nosy: +python-dev ___ Python tracker

[issue20021] "modernize" makeopcodetargets.py

STINNER Victor added the comment: issue20021_2.diff looks good to me. -- ___ Python tracker ___ ___

[issue20021] "modernize" makeopcodetargets.py

STINNER Victor added the comment: > Victor went with a different solution in f682b620c64d. Oh sorry, I wasn't aware of this old issue. My motivation was to get ride of the deprecated imp module, this script looks to be the latest part of the Python which uses the imp module (except of

[issue20021] "modernize" makeopcodetargets.py

Serhiy Storchaka added the comment: f682b620c64d looks incorrect to me. It makes makeopcodetargets.py to use the opcode module of Python that executes the script. Instead the script should use the opcode module from the same source tree as the script. I think f682b620c64d should be reverted.

[issue20021] "modernize" makeopcodetargets.py

Berker Peksag added the comment: Victor went with a different solution in f682b620c64d. -- nosy: +haypo resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue20021] "modernize" makeopcodetargets.py

Serhiy Storchaka added the comment: Some of the buildbots have Python 2.5 as their system Python. Here is a patch that is compatible with older Python versions. -- nosy: +serhiy.storchaka versions: +Python 3.6 -Python 3.5 Added file: http://bugs.python.org/file40670/issue20021_2.diff

[issue20021] "modernize" makeopcodetargets.py

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___

[issue20021] modernize makeopcodetargets.py

R. David Murray added the comment: The comment about staying compatibler with 2.3 is now clearly out of date :) -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20021

[issue20021] modernize makeopcodetargets.py

Berker Peksag added the comment: I think makeopcodetargets.py should still be compatible with Python 2 (2.6 or 2.7 at least) since it uses the system Python. I'd suggest closing this as rejected (or just commit the ``with open(...):`` part of the patch and update the outdated comment).

[issue20021] modernize makeopcodetargets.py

Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +easy stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20021 ___

[issue20021] modernize makeopcodetargets.py

Berker Peksag added the comment: Here's a patch. -- keywords: +patch nosy: +berker.peksag, brett.cannon stage: needs patch - patch review Added file: http://bugs.python.org/file36745/issue20021.diff ___ Python tracker rep...@bugs.python.org

[issue20021] modernize makeopcodetargets.py

New submission from Eric Snow: Python/makeopcodetargets.py uses deprecated imp APIs. It should be refactored to use newer import-related APIs. -- components: Library (Lib) messages: 206577 nosy: eric.snow priority: low severity: normal status: open title: modernize