Roundup Robot added the comment:
New changeset 951318b651be by Zachary Ware in branch 'default':
Issue #20035: Reimplement tkinter._fix module as a C function.
https://hg.python.org/cpython/rev/951318b651be
--
___
Python tracker
Zachary Ware added the comment:
Committed, thanks for the reviews, Serhiy and Steve!
--
assignee: - zach.ware
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Steve Dower added the comment:
Use !='true' rather than =='', but otherwise it's good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20035
___
Zachary Ware added the comment:
I committed a presence test for Tix in #21337 that should catch problems with
loading Tix after this patch. There shouldn't be any problem though, we
actually install Tix into Tcl/Tk whereas TIX_LIBRARY is (to my understanding)
for helping Tcl/Tk find a Tix
Steve Dower added the comment:
There's an MSBuild property that I set for release builds (either
BuildForRelease or ReleaseBuild, not Configuration) that should exclude the
preprocessor directive so we don't include an unnecessary full path. I can make
that change later if you don't want to
Zachary Ware added the comment:
Here's a new patch that actually applies, and has a couple of improvements.
I'd greatly appreciate some review on this; I'm planning on committing before
beta1 anyway.
--
nosy: +paul.moore, steve.dower, tim.golden
priority: normal - high
Added file:
Serhiy Storchaka added the comment:
I afraid about Tix. _fix.py searches not only Tcl/Tk, but Tix too. New patch
doesn't set TIX_LIBRARY. Unfortunately there are no Tix tests at all, and we
can break the support of Tix without the notice.
--
___
Mark Lawrence added the comment:
ping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20035
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Stefan Behnel sco...@users.sourceforge.net:
--
nosy: -scoder
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20035
___
___
Mark Lawrence added the comment:
Can we have (hopefully) a final review and get this committed as that would
also allow us to close #10652.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20035
Zachary Ware added the comment:
Ok, here's another attempt which should address both points you raised, Serhiy.
I don't have an East-Asian Windows install to test on (and wouldn't be able to
read anything to do the test, anyway!), but I did test with a prefix containing
East-Asian characters
Zachary Ware added the comment:
Thank you, Serhiy; those are exactly the kinds of things I don't know enough
about and had concerns about. I'll take another stab and see if I can come up
with anything better. Suggestions welcome :)
--
___
Python
Zachary Ware added the comment:
Ping. I still want to get this in, but not without a proper review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20035
___
Serhiy Storchaka added the comment:
I want to get this too, but perhaps there are some issues in a code.
1. Py_GetPrefix() returns wchar_t* string with maximal length MAXPATHLEN
(defined in Include/osdefs.h as 256 on Windows). Then wcstombs() converts it to
char* string. Are you sure that
Zachary Ware added the comment:
Ok, debugging again with better breakpoints, I see what I missed before, so
here's a new patch that does things a little differently. This patch sets the
TCL_LIBRARY envvar just before calling Tcl_FindExecutable, and unsets it after
the call. The $tcl_library
Serhiy Storchaka added the comment:
TCL_VERSION should be set before call of Tcl_FindExecutable() (for correct Tcl
encodings initialization). Tcl_FindExecutable() is called in PyInit__tkinter().
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
Serhiy Storchaka wrote:
TCL_VERSION should be set before call of Tcl_FindExecutable() (for correct Tcl
encodings initialization). Tcl_FindExecutable() is called in
PyInit__tkinter().
I assume you mean TCL_LIBRARY (since TCL_VERSION is #defined in Tcl.h)? You
Zachary Ware added the comment:
Here's an even less ugly new version of the patch; it does everything with
multi-byte strings instead of wide-char strings (so that there's just one
conversion of prefix from wcs to mbs at the beginning of the block, and
TCL_VERSION is used directly). This
Zachary Ware added the comment:
Also, I have confirmed that the blind symlink issue in non-English Windows
Vista (issue3881) is not a problem in Tcl/Tk 8.6. That issue was easy to
reproduce in a standard installation of Python 3.3 (with Tcl/Tk 8.5) on German
Windows Vista by setting
19 matches
Mail list logo
