[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2021-12-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue22815. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e75ab9fd760 by Gregory P. Smith in branch 'default': Fixes Issue #20165: The unittest module no longer considers tests marked with http://hg.python.org/cpython/rev/1e75ab9fd760 -- nosy: +python-dev ___

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-20 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20165 ___

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-09 Thread Stefano Lattarini
Stefano Lattarini added the comment: Since I too was bitten by this issue, I'd like to support Gregory's request, and report my rationale for changing the current behaviour. With the current behaviour, we could see (and I *have* seen) scenarios like this: 1. A test exposing a known

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-08 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm not comfortable changing this for 2.7 or 3.3 in case some code is unfortunately is depending on this behavior. But as it is it does seem like the kind of thing that can hide problems (tests that are passing that are not expected to). Here's a patch

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-07 Thread Gregory P. Smith
New submission from Gregory P. Smith: Python 3.3.3+ (3.3:28337a8fb502+, Jan 7 2014, 01:32:44) [GCC 4.6.3] on linux Type help, copyright, credits or license for more information. import unittest r = unittest.result.TestResult() r.wasSuccessful() True r.addUnexpectedSuccess(weird!)

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: somewhat related - https://code.google.com/p/unittest-ext/issues/detail?id=22 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20165 ___

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-07 Thread Gregory P. Smith
Changes by Gregory P. Smith g...@krypto.org: -- nosy: +michael.foord ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20165 ___ ___ Python-bugs-list

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-07 Thread Michael Foord
Michael Foord added the comment: I'm pretty sure this has been debated before (and the status quo is the result). Trying to find the issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20165

[issue20165] unittest TestResult wasSuccessful returns True when there are unexpected successes

2014-01-07 Thread Michael Foord
Michael Foord added the comment: Hmmm... TestTools has wasSuccessful return False on an unexpected success [1] and I can't find an issue for any previous discussion. I don't use unexpected success, so I have no particular horse in this race but it seems more logical that wasSuccessful should