Zachary Ware added the comment:
Yep, Windows is happy with the latest patch.
Since this is such an enormous patch, I'm assuming it's only going into 3.5 and
have changed the version field accordingly.
--
versions: +Python 3.5 -Python 3.4
___
Python
Larry Hastings added the comment:
Yeah, I've been meaning to mark all the Derby patches as 3.5. We're not adding
new Clinic conversions to 3.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20170
Roundup Robot added the comment:
New changeset 0c57aba6b1a3 by Larry Hastings in branch 'default':
Issue #20170: Convert posixmodule to use Argument Clinic.
http://hg.python.org/cpython/rev/0c57aba6b1a3
--
nosy: +python-dev
___
Python tracker
Larry Hastings added the comment:
Gonna keep an eye on the buildbots and make sure I haven't caused any new
breakage. Otherwise... fingers crossed, I think it's done! Thanks for the
help everybody (particularly Zach!).
--
___
Python tracker
Changes by Larry Hastings la...@hastings.org:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20170
___
Larry Hastings added the comment:
Diff tweaked to undo the ill-concieved Py_RETURN_NONE change. Thanks, Zachary!
Does it now compile and pass tests on Windows?
--
Added file: http://bugs.python.org/file36240/larry.clinicize.posixmodule.7.diff
___
Zachary Ware added the comment:
Another nit to pick: long lines in docstrings. There are several lines about
75-78 characters long in several different docstrings, which look absolutely
terrible when you try import os;help(os) on an 80-character-wide terminal due
to an 8 character indent.
Zachary Ware added the comment:
The patch applies and compiles cleanly, and I finally tracked down what was
causing the errors I reported yesterday: os_utime_impl was changed to use
Py_RETURN_NONE instead of just setting return_value = Py_None, so Windows
skipped the exit routine and left an
Larry Hastings added the comment:
Here's a fresh diff. I did some cleanup this time (Clinic now generates the
#ifndef versions of the METHODDEF structures) and I believe solved everything
MSVC complains about.
Zachary, can you try this one?
--
Added file:
Zachary Ware added the comment:
Close, but no cigar :). Posted Rietveld comments to address the last two
compile issues (one of which also appears to be a major bug, but only a warning
at compile time).
Also, Victor has added os.get_blocking() and os.set_blocking(), which prevent
your patch
Larry Hastings added the comment:
Two small fixes from Zach (thanks again Zach!) and I updated against current
trunk so it should apply cleanly. How's it look now?
--
Added file: http://bugs.python.org/file36172/larry.clinicize.posixmodule.6.diff
Larry Hastings added the comment:
Here's an updated patch. I cleaned it up a little. I think it's about ready
to go in.
Zachary, iirc you're a Windows guy and have helped with ensuring patches apply
cleanly to Windows in the past. Can you give this a try on Windows?
--
Added file:
Zachary Ware added the comment:
MSVC is not happy, here's some build output:
P:\ath\to\cpython\PCbuild\pcbuild.sln (Build target) (1) -
P:\ath\to\cpython\PCbuild\python.vcxproj (default target) (2) -
P:\ath\to\cpython\PCbuild\pythoncore.vcxproj (default target) (3) -
(ClCompile target) -
Larry Hastings added the comment:
thanks! I'm flying from London to Brisbane (via Singapore), gonna take about a
day. Now I have something to do on the flight ;-)
(that and nullable ints)
--
___
Python tracker rep...@bugs.python.org
Martin v. Löwis added the comment:
This patch doesn't apply anymore (to c55300337932); please update it.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20170
___
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20170
___
___
Python-bugs-list
Larry Hastings added the comment:
Here's a complete patch, converts everything that I think should be converted
for 3.4. With this patch applied, all unit tests pass on my 64-bit Linux box.
I plan to also run tests with the buildbots before checking it in.
The patch... well, it's 14,000
Larry Hastings added the comment:
By the way, my plan is to turn on the file preset just before checkin. The
patch is *much* easier to read without turning that on first; with the file
preset, now you have to keep two windows in sync to compare calls to PyArg_*().
--
Larry Hastings added the comment:
Sorry for the fresh update, but here's revision 3. Only changes:
* Gave os.access a - bool return converter.
* Fixed up a lot of whitespace. Now, major things are separated by
two empty lines, but removed whitespace between
#ifdef HAVE_SOMETHING
Larry Hastings added the comment:
Actually, forget about the file output preset. It wouldn't work for
posixmodule. 80% of the entry points are #ifdef conditional on platform
functionality. Which means the Clinic generated stuff needs to be #ifdef too.
It wouldn't be that hard to add the
Serhiy Storchaka added the comment:
The curses module also has many conditionally implemented functions.
I think Argument Clinic can detect preprocessor instructions
(#if/#ifdef/#ifndef/#else/#endif) and generate needed #if/#endif in generated
file. This would be more robust than explicitly
Larry Hastings added the comment:
That's a really good idea! I'm still thinking about how I'd do it, but I think
I'm gonna give it a try.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20170
Larry Hastings added the comment:
Submitting this just so I beat the deadline. I'm *about* half done, but I'm
still working on it, so I'm just going to keep going--should only be another
couple of hours.
(If somebody else pulls this stunt, I guess I'll accept their final patch too.)
New submission from Larry Hastings:
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of files:
Changes by Larry Hastings la...@hastings.org:
--
components: +Extension Modules -Library (Lib)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20170
___
Changes by Larry Hastings la...@hastings.org:
--
type: behavior - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20170
___
___
26 matches
Mail list logo
