Benjamin Peterson added the comment:
I don't mind if you fix it in 2.7, too.
(Sorry, I get a lot of bug related emails...)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
___
Changes by Larry Hastings la...@hastings.org:
--
assignee: ghaering - larry
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
Serhiy Storchaka added the comment:
Is 2.7 affected?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
___
___
Python-bugs-list mailing list
Larry Hastings added the comment:
I'm gonna fix this now. (I'm cleaning up some old issues I filed on the bug
tracker this morning.)
For 3.4, I'm just removing the PyObject *kwargs for those three functions that
don't actually accept keyword arguments (METH_VARARGS) and aren't passed that
Roundup Robot added the comment:
New changeset 4c860369b6c2 by Larry Hastings in branch '3.4':
Issue #20274: Remove ignored and erroneous kwargs parameters from three
https://hg.python.org/cpython/rev/4c860369b6c2
New changeset 3e9f4f3c7fa7 by Larry Hastings in branch 'default':
Issue #20274:
Changes by Larry Hastings la...@hastings.org:
--
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
___
___
Larry Hastings added the comment:
Yes, all those bugs exist in 2.7. However, Benjamin hasn't responded to this
bug, so I assume he doesn't care and I should leave 2.7 alone.
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
I think the bug should be fixed in 2.7 (but not in 3.3 unless we get a crasher).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
___
Larry Hastings added the comment:
Benjamin: I assume you want the extraneous (and undefined behavior) kwargs
parameters removed.
Do you also want pysqlite_connection_call() to start calling
_PyArg_NoKeywords()?
--
___
Python tracker
Benjamin Peterson added the comment:
On Fri, May 8, 2015, at 12:08, Larry Hastings wrote:
Larry Hastings added the comment:
Benjamin: I assume you want the extraneous (and undefined behavior)
kwargs parameters removed.
Do you also want pysqlite_connection_call() to start calling
Roundup Robot added the comment:
New changeset c91d135b0776 by Larry Hastings in branch '2.7':
Issue #20274: When calling a _sqlite.Connection, it now complains if passed
https://hg.python.org/cpython/rev/c91d135b0776
--
___
Python tracker
Changes by Larry Hastings la...@hastings.org:
--
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
___
___
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
___
___
New submission from Larry Hastings:
The code in Modules/_sqlite/connection.c is sloppy.
The functions pysqlite_connection_execute, pysqlite_connection_executemany, and
pysqlite_connection_executescript accept a third PyObject *kwargs. However
none of these functions are marked METH_KEYWORD.
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
___
___
R. David Murray added the comment:
Why do you want to fix it in order versions? Can it lead to a crash?
For __call__, it seems to me we should do a deprecation and remove it in 3.5.
Otherwise we'll risk breaking working code for no good reason (working code
with useless parameters, but
Larry Hastings added the comment:
You're right, deprecation sounds best. If Georg or Benjamin want the fix in
earlier releases I'll split the pysqlite_connection_call into another issue,
otherwise I won't bother.
As for fixing the undefined behavior in older versions: since its behavior is
17 matches
Mail list logo
