Changes by Berker Peksag berker.pek...@gmail.com:
--
resolution: - fixed
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
___
Roundup Robot added the comment:
New changeset 871278b87c62 by Eli Bendersky in branch '3.4':
Issue #20375: Clarify ET's parsing of comments and processing instructions.
http://hg.python.org/cpython/rev/871278b87c62
New changeset 5c3166ec80e1 by Eli Bendersky in branch 'default':
Issue #20375:
Eli Bendersky added the comment:
Thanks. Doc patch committed with some slight rewording.
Would you like to prepare a separate patch for the tests, default branch only
this time?
--
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
Nikolaus Rath added the comment:
Thanks for the commit!
My intention is to fix the behavior itself for 3.5 (see issue 9521), so I think
adding testcases for the old behavior in the meantime isn't necessary.
--
___
Python tracker
Eli Bendersky added the comment:
On Thu, Apr 3, 2014 at 1:19 PM, Nikolaus Rath rep...@bugs.python.orgwrote:
Nikolaus Rath added the comment:
Thanks for the commit!
My intention is to fix the behavior itself for 3.5 (see issue 9521), so I
think adding testcases for the old behavior in the
Changes by Nikolaus Rath nikol...@rath.org:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
___
___
Python-bugs-list
Eli Bendersky added the comment:
I left some comments in Rietveld.
There shouldn't be a problem getting these into 3.4 too - doc changes are
usually excempt from most restrictions.
--
___
Python tracker rep...@bugs.python.org
Nikolaus Rath added the comment:
Thanks for your feedback! I've attached an updated patch.
--
Added file: http://bugs.python.org/file34708/issue20375.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
Changes by Nikolaus Rath nikol...@rath.org:
Added file: http://bugs.python.org/file34709/issue20375.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
___
Eli Bendersky added the comment:
The patch appears to contain code (tests) along with the documentation. Is this
intended? This issue is not tagged properly if it is.
I'd suggest to split them to separate patches.
--
versions: +Python 3.5 -Python 2.7, Python 3.3, Python 3.4
Nikolaus Rath added the comment:
Yes, the new testcases were deliberately included. I submitted the patch prior
to the 3.4 release, am I right that at that point this wouldn't have been a
problem?
I have attached a new patch containing just the doc changes. I hope that's
still acceptable for
Stefan Behnel added the comment:
I think you attached the wrong file.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
___
___
Changes by Nikolaus Rath nikol...@rath.org:
Removed file: http://bugs.python.org/file34528/issue20951.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
___
Nikolaus Rath added the comment:
Indeed I did, here's the correct patch. Thanks!
--
Added file: http://bugs.python.org/file34622/issue20375.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
Claudiu.Popa added the comment:
Hello. I left a couple of comments on Rietveld.
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
___
Changes by Nikolaus Rath nikol...@rath.org:
Added file: http://bugs.python.org/file34528/issue20951.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20375
___
Nikolaus Rath added the comment:
I've also attached a testcase to confirm that the docpatch reflects current
behavior, and to make sure that anticipated enhancements in Python 3.5 behave
in a backwards compatible way.
--
Added file:
New submission from Nikolaus Rath:
(This issue was branched of from #9521).
When parsing XML, etree currently skips over all processing instructions and
comments. However, both can be represented in the tree and are also written out
when generating XML.
The attached patch documents this (IMO
18 matches
Mail list logo
