Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: pending - closed
type: - compile error
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20394
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20394
___
___
Mark Lawrence added the comment:
Can we have a decision as to whether or not the patch should be back ported to
2.7.
--
nosy: +BreamoreBoy
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20394
Serhiy Storchaka added the comment:
Christian, what about 2.7?
--
status: open - pending
versions: -Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20394
___
Roundup Robot added the comment:
New changeset 0a406b6fe61f by Christian Heimes in branch 'default':
I forgot to add a Misc/NEWS entry for issue #20394
http://hg.python.org/cpython/rev/0a406b6fe61f
--
___
Python tracker rep...@bugs.python.org
Christian Heimes added the comment:
The commit has silenced coverity's warning.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20394
___
___
Terry J. Reedy added the comment:
Coverity appears concerned about the division by q. It apparently knows inrate
!= 0. I do not see any division by len. If q is cleared up, I presume it will
check bytes_per_frame.
--
nosy: +terry.reedy
___
Python
Christian Heimes added the comment:
Coverity is concerned about the value of `q` when `len 0`. The expression
Py_ssize_t q = len 0 ? 1 + (len - 1) / inrate : 0;
returns a positive, non-null value for len 0. Another check ensures that len
!= 0 a couple of lines earlier. In theory it is
Roundup Robot added the comment:
New changeset bf52f2dbfdde by Christian Heimes in branch 'default':
Issue #20394: Attempt to silence CID 1164423: Division or modulo by zero in
audioop_ratecv_impl()
http://hg.python.org/cpython/rev/bf52f2dbfdde
--
nosy: +python-dev
Serhiy Storchaka added the comment:
If Coverity is silenced, this patch should be backported to 2.7 and 3.3.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20394
___
New submission from Serhiy Storchaka:
Christian Heimes reported
(http://permalink.gmane.org/gmane.comp.python.devel/145253) Coverity issue:
** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO)
/Modules/audioop.c: 1375 in audioop_ratecv_impl()
11 matches
Mail list logo