[issue20440] Use the Py_SETREF macro

Serhiy Storchaka added the comment: The commit doesn't include changes for dictobject.c, setobject.c and _sqlite/cache.c (I had forgot to exclude them from the patch before uploading). Dict and set code is performance critical, and using Py_XDECREF instead of Py_DECREF can affect performance.

[issue20440] Use the Py_SETREF macro

Roundup Robot added the comment: New changeset 1118dfcbcc35 by Serhiy Storchaka in branch 'default': Issue #20440: Cleaning up the code by using Py_SETREF. https://hg.python.org/cpython/rev/1118dfcbcc35 -- ___ Python tracker

[issue20440] Use the Py_SETREF macro

Serhiy Storchaka added the comment: The final patch replaces the code that equivalent to the Py_SETREF macro by using the Py_SETREF macro. There are no bugs, the patch only makes the correct code cleaner. If I'll not got a review, I'll just close this issue. -- versions: -Python 2.7,

[issue20440] Use the Py_SETREF macro

Roundup Robot added the comment: New changeset e04cd497aa41 by Zachary Ware in branch 'default': Issue #25972, #20440: Fix compilation on Windows https://hg.python.org/cpython/rev/e04cd497aa41 -- ___ Python tracker

[issue20440] Use the Py_SETREF macro

Roundup Robot added the comment: New changeset 9fb57c0209ea by Serhiy Storchaka in branch '3.5': Issue #20440: Applied yet one patch for using Py_SETREF. https://hg.python.org/cpython/rev/9fb57c0209ea New changeset bc7c56a225de by Serhiy Storchaka in branch 'default': Issue #20440: Applied yet

[issue20440] Use the Py_SETREF macro

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file41430/py_setref_extra2.patch ___ Python tracker ___

[issue20440] Use the Py_SETREF macro

Roundup Robot added the comment: New changeset 4bfbb2714ae9 by Serhiy Storchaka in branch '3.5': Issue #20440: More use of Py_SETREF. https://hg.python.org/cpython/rev/4bfbb2714ae9 New changeset 11670e4be1a9 by Serhiy Storchaka in branch '2.7': Issue #20440: More use of Py_SETREF.

[issue20440] Use the Py_SETREF macro

Roundup Robot added the comment: New changeset 23296440b654 by Serhiy Storchaka in branch '2.7': Issue #20440: Massive replacing unsafe attribute setting code with special https://hg.python.org/cpython/rev/23296440b654 New changeset fd36d72f6030 by Serhiy Storchaka in branch '3.5': Issue

[issue20440] Use the Py_SETREF macro

Serhiy Storchaka added the comment: Committed patches were generated with attached Coccinelle script. -- Added file: http://bugs.python.org/file41401/py_setref.cocci ___ Python tracker

[issue20440] Use the Py_SETREF macro

Serhiy Storchaka added the comment: Following patch is manually crafted and covers the rest cases. It also replaces existing correct attribute replacing using a temporary variable with more compact call of the macro. -- Added file:

[issue20440] Use the Py_SETREF macro

Changes by Serhiy Storchaka : -- title: Use Py_REPLACE/Py_XREPLACE macros -> Use the Py_SETREF macro ___ Python tracker ___