[issue20486] msilib: can't close opened database

Berker Peksag added the comment: Thank you, all. The OP's snippet should work now: >>> import msilib as m >>> db = m.OpenDatabase('py33.msi', m.MSIDBOPEN_TRANSACT) >>> db.Commit() >>> db2 = m.OpenDatabase('py33.msi', m.MSIDBOPEN_TRANSACT) Traceback (most recent call last): File "", line 1, in

[issue20486] msilib: can't close opened database

Berker Peksag added the comment: New changeset a935654f0613640535fbf0ba190f81d02a63d35c by Berker Peksag in branch 'master': bpo-20486: Implement Database.Close() method in msilib (GH-4141) https://github.com/python/cpython/commit/a935654f0613640535fbf0ba190f81d02a63d35c --

[issue20486] msilib: can't close opened database

Change by Berker Peksag : -- pull_requests: +4105 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue20486] msilib: can't close opened database

xoviat added the comment: Unfortunately, this issue has taken on a much lower importance for me, and as such, I won't be able to address it. Sorry about that. 2017-10-26 0:01 GMT-05:00 Berker Peksag : > > Berker Peksag added the comment: > > xoviat, would you like to send your patch as a pull

[issue20486] msilib: can't close opened database

Berker Peksag added the comment: xoviat, would you like to send your patch as a pull request on GitHub? It would be nice to add a simple test that the new Close() works correctly. I can do that if you don't have time, thank you! Steve, can we apply this to bugfix branches? -- version

[issue20486] msilib: can't close opened database

Changes by 12345 67890 : Removed file: http://bugs.python.org/file45971/Add_ability_to_close_MSI_database_.patch ___ Python tracker ___ ___ P

[issue20486] msilib: can't close opened database

12345 67890 added the comment: The method is now capitalized. Unfortunately, none of the methods are compliant with PEP formatting, but it's far too late to do anything about that. -- Added file: http://bugs.python.org/file46056/Add_ability_to_close_MSI_database_.patch ___

[issue20486] msilib: can't close opened database

Berker Peksag added the comment: Thanks for the patch, 12345. Steve knows better, but I think the method should be named "Close" instead of "close" like _msi.View's Close method. Also, I couldn't apply your patch: $ hg imp http://bugs.python.org/file45971/Add_ability_to_close_MSI_database_.pa

[issue20486] msilib: can't close opened database

Changes by 12345 67890 : -- keywords: +patch Added file: http://bugs.python.org/file45971/Add_ability_to_close_MSI_database_.patch ___ Python tracker ___ ___

[issue20486] msilib: can't close opened database

Changes by 12345 67890 : Removed file: http://bugs.python.org/file45970/_msi.c ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue20486] msilib: can't close opened database

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20486] msilib: can't close opened database

12345 67890 added the comment: I will prefix this by saying that I have not contributed to the Python source before and this patch is probably wrong, but here is my attempt at a fix. -- Added file: http://bugs.python.org/file45970/_msi.c ___ Python t

[issue20486] msilib: can't close opened database

Steve Dower added the comment: Guessing the msiobj_close function in PC/_msi.c ought to be exposed. Patches welcome. -- keywords: +easy priority: normal -> low stage: -> needs patch versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue20486] msilib: can't close opened database

12345 67890 added the comment: This is still present in Python 3.5. There is no way to unlock the MSI file without killing the Python process first. -- nosy: +12345 67890 versions: +Python 3.5 ___ Python tracker _

[issue20486] msilib: can't close opened database

Mark Lawrence added the comment: Sorry folks I can't try this myself as I'm not running 2.7 and I don't know how to create the test.msi file. -- nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware ___ Python tracker

[issue20486] msilib: can't close opened database

Changes by Ned Deily : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue20486] msilib: can't close opened database

New submission from Игорь Шаула: In Python 2.7.6 can't find any way to close MSI database after finish working with it. As a result database is locked and can't be opened by any other application until Python process is finished. import msilib db = msilib.OpenDatabase('test.msi', msili