[issue20487] Odd words in unittest.mock document.

Berker Peksag added the comment: Fixed. Thank you to both Andrew and Michael. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue20487] Odd words in unittest.mock document.

Roundup Robot added the comment: New changeset 230a1bfb0f59 by Berker Peksag in branch '3.4': Issue #20487: Clarify meaning of "side effect" in the magic mock documentation. https://hg.python.org/cpython/rev/230a1bfb0f59 New changeset 3cf91d2aeab3 by Berker Peksag in branch 'default': Issue #204

[issue20487] Odd words in unittest.mock document.

Michael Foord added the comment: Patch looks good, thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue20487] Odd words in unittest.mock document.

Berker Peksag added the comment: Here is a patch to address msg211296. -- keywords: +patch nosy: +berker.peksag stage: -> patch review type: -> enhancement versions: -Python 3.3 Added file: http://bugs.python.org/file37602/issue20487.diff ___ Pytho

[issue20487] Odd words in unittest.mock document.

Changes by A.M. Kuchling : -- nosy: -akuchling ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue20487] Odd words in unittest.mock document.

A.M. Kuchling added the comment: Maybe this would be clearer if it used the keyword, i.e. "using the :attr:`~Mock.side_effect` attribute". Also, there's a typo in the quoted text: "two equality method" should be method'S'. -- nosy: +akuchling ___ P

[issue20487] Odd words in unittest.mock document.

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20487] Odd words in unittest.mock document.

Michael Foord added the comment: A "side effect" is a mechanism Mock provides for mocks to have special behaviour when called. http://docs.python.org/3.3/library/unittest.mock.html#unittest.mock.Mock.side_effect The term is used very widely throughout the mock documentation, so I don't think

[issue20487] Odd words in unittest.mock document.

New submission from INADA Naoki: http://docs.python.org/3.3/library/unittest.mock.html#magic-mock > The two equality method, __eq__ and __ne__, are special. They do the default > equality comparison on identity, using a side effect, unless you change their > return value to return something el