Roundup Robot added the comment:
New changeset 51de0da524b4 by Terry Jan Reedy in branch '2.7':
Issue #20577: move configuration of FormatParagraph extension to new extension
https://hg.python.org/cpython/rev/51de0da524b4
New changeset 3ffa8438d274 by Terry Jan Reedy in branch '3.4':
Issue
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: - terry.reedy
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
Changes by Terry J. Reedy tjre...@udel.edu:
--
dependencies: +IDLE - Add an extension configuration dialog
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
___
Tal Einat added the comment:
I don't think this is a major issue. Most users only use one version of IDLE
with one version of Python.
IDLE's user config is indeed shared between all versions. This is an
unfortunate design mistake, and could perhaps be fixed in 3.5.
Regarding this issue, we
Terry J. Reedy added the comment:
The awkwardness of the config design is that idlelib/config-xyz.def files are
separate for each version and shared across users (and systems) while
.idlerc/config-xyz.def files are separate for each user (account) and shared
across versions on the same
Tal Einat added the comment:
So is that a go-ahead to commit to the 2.7 and 3.4 branches (as well as
default)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
___
Terry J. Reedy added the comment:
What I meant was 'wait until we have an new announcement mechanism', which we
very much need anyway, and then apply to all three. And that should have been
'Help/What's New' in the splash announcement. I opened #21961 for this and will
try to have a minimal
Terry J. Reedy added the comment:
Ned's comments on #20580, msg222714, reminded me that while each idlelib has
its own set of default config files, one set of user files is shared across all
installed versions of idle. So we have to be careful about what we do. With
this patch, 3.4.2, for
Terry J. Reedy added the comment:
This will at least need a What's New entry, though people do not expect new
entries in maintenance releases. I think we need an Idle What's New accessible
from the help menu and announced on the splash screen. Unlike the standard
What's New, it will get
Tal Einat added the comment:
I've been waiting to commit this for some time. I'd really like to do this
myself, if you don't mind.
I'm just waiting for my SSH key to be added, which is taking a long time since
apparently all three people who could do so are traveling and unable to help.
Terry J. Reedy added the comment:
Since you are busy, I am planning to commit this tomorrow so I can review the
extension config patch with this in place.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
Tal Einat added the comment:
With very minor changes (just use default=72 instead of or 72 and added a
comment explaining why 72 is the default - see attached), I ran the entire test
suite (which is a must according to the dev guide). On current default I'm
getting consistent failures in
Tal Einat added the comment:
Also, this seems like a small change. Should I mention it in Misc/NEWS?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
___
Terry J. Reedy added the comment:
General rule: If the other failures happen without the patch, then go ahead.
This is, unfortunately, all too common. If they only happen with the patch
(extremely unlikely for this one), then try to find out why.
Yes, this change should have a NEWS item.
Tal Einat added the comment:
What do you mean with the comment regarding pep8?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
___
___
Terry J. Reedy added the comment:
For flowing long blocks of text with fewer structural restrictions (docstrings
or comments), the line length should be limited to 72 characters.
--
___
Python tracker rep...@bugs.python.org
Tal Einat added the comment:
I'll be damned. 72 it is, then.
What about using the 'default' parameter for GetOption() instead of or 72?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
Terry J. Reedy added the comment:
'yes!' meant please do so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20577
___
___
Python-bugs-list
Terry J. Reedy added the comment:
I updated the patch to match a change, since you posted this, from 70 to 72 in
.def and 'maxformatwidth' to ' limit' in formatparagraph. I also added a
'guard' value of 72 in case GetOption returns None (as it did before I changed
the option name). I checked
Tal Einat added the comment:
Thanks for reviewing this Terry! See two small comments in the review of your
patch.
Indeed, I would very much like for this to be my first commit. Thanks for the
pointer WRT backporting to 2.7. Just to make sure, I should commit to 3.5
(default) and then
Terry J. Reedy added the comment:
Backwards from default was the old, svn way. We hg we merge forward within 3.x.
ready to commit to 3.4 and merge to 3.5.. If you started with 3.5, then you
would have to do a null merge of the 3.4 patch into 3.5. It is occasionally
done when people decide to
New submission from Tal Einat:
Following up issue3068, this is a separate patch which moves the paragraph
reformat width setting from the general tab in IDLE's config dialog to the
relevant place in the extensions configuration.
--
components: IDLE
files:
22 matches
Mail list logo
