[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg296105 ___ Python tracker ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Serhiy Storchaka added the comment: New changeset 96c7c0685045b739fdc5145018cddfd252155713 by Serhiy Storchaka (Sylvain) in branch 'master': bpo-20627: Fix error message when keyword arguments are used (#2115) https://github.com/python/cpython/commit/96c7c0685045b739fdc5145018cddfd252155713

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Changes by SylvainDe : -- pull_requests: +2168 ___ Python tracker ___ ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Roundup Robot added the comment: New changeset 395904f70d6a by Brett Cannon in branch 'default': Issue #20627: xmlrpc.client.ServerProxy is now a context manager. http://hg.python.org/cpython/rev/395904f70d6a -- nosy: +python-dev ___ Python tracker

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Brett Cannon added the comment: Thanks for the patch! -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Claudiu.Popa added the comment: My pleasure! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___ ___ Python-bugs-list mailing list

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Claudiu.Popa added the comment: Now that the 3.5 branch is the default, can this feature be committed? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Brett Cannon added the comment: Yes it can. I do my Python work typically on Fridays so I will get to it then. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Éric Araujo added the comment: Looks good to me; left some comments on Rietveld. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___ ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Claudiu.Popa added the comment: Thanks for the review, Éric! I uploaded a new version of the patch, which addresses your comments. -- keywords: +patch Added file: http://bugs.python.org/file34374/issue20627_1.patch ___ Python tracker

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Claudiu.Popa added the comment: Patch updated with fixes suggested by Éric. -- Added file: http://bugs.python.org/file34378/issue20627_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Changes by Claudiu.Popa pcmantic...@gmail.com: Added file: http://bugs.python.org/file34379/issue20627_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Éric Araujo added the comment: This looks ready to me. Thanks Claudiu! -- keywords: -needs review stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Claudiu.Popa added the comment: My pleasure. Thanks for the reviews, too! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___ ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Jessica McKellar added the comment: Thanks for the patch, Claudiu.Popa! I noticed one tiny thing, which is that it introduced some trailing whitespace. I've uploaded a trivial change to your patch that removes the whitespace. * The patch applies cleanly. * The docs build cleanly with the

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Claudiu.Popa added the comment: Cool, thanks, Jessica! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___ ___ Python-bugs-list mailing

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Claudiu.Popa added the comment: Hi. Here's a simple patch for this. -- keywords: +patch nosy: +Claudiu.Popa Added file: http://bugs.python.org/file34107/xmlrpc.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Brett Cannon added the comment: Thanks for the patch, Cladiu! Since the 3.5 branch is not open yet it might not be until late March or April when I can look at this patch and get it committed, but I will get to it. -- assignee: - brett.cannon ___

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

New submission from Brett Cannon: Otherwise have to call client('close')() to close a server proxy and that's just ugly. -- components: Library (Lib) messages: 211221 nosy: brett.cannon priority: normal severity: normal stage: test needed status: open title: Add context manager support

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +easy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___ ___ Python-bugs-list

[issue20627] Add context manager support to xmlrpc.client.ServerProxy

Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo stage: test needed - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20627 ___