STINNER Victor added the comment:
Can I close this issue now?
Yes. If something really critical appears, a new issue can be opened.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Larry Hastings added the comment:
Can I close this issue now?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20648
___
___
Python-bugs-list
Larry Hastings added the comment:
I just put the third preview up. There are no diffs between that asyncio and
the one in default.
Is this torrent coming to a close? We really should keep the changes from rc2
to final to a bare minimum.
--
___
STINNER Victor added the comment:
Is this torrent coming to a close? We really should keep the changes from
rc2 to final to a bare minimum.
I agree.
We may improve the documentation, but such commits doesn't need to be
cherry-picked. Many people read the documentation online
STINNER Victor added the comment:
Should these be cherry-picked too?
We discuss with Guido and Yury to only include critical changes, so in short:
yes, all commits related to asyncio should be cherrry-picked into RC2. It
should also be easier for you to include all changes, to avoid
STINNER Victor added the comment:
changeset: 89300:c3abdf016b18
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Thu Feb 20 10:12:59 2014 +0100
files: Lib/asyncio/subprocess.py
description:
asyncio.subprocess: Fix a race condition in communicate()
Use
STINNER Victor added the comment:
changeset: 89302:3e19634b396f
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Thu Feb 20 10:37:27 2014 +0100
files: Lib/asyncio/events.py Lib/asyncio/futures.py Lib/asyncio/tasks.py
Lib/asyncio/test_utils.py
STINNER Victor added the comment:
Sorry, I found new bugs /o\
You may skip 3e19634b396f if the last commit to cherry-pick, it's just cleanup.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20648
STINNER Victor added the comment:
You may skip 3e19634b396f if the last commit to cherry-pick, it's just
cleanup.
(Ooops, if *it is* the last commit)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20648
STINNER Victor added the comment:
changeset: 89303:d1f0ec5a9317
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Thu Feb 20 16:43:09 2014 +0100
files: Lib/asyncio/base_events.py
description:
asyncio: Fix _check_resolved_address() for IPv6 address
STINNER Victor added the comment:
changeset: 89304:03b14690a9be
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Thu Feb 20 17:01:11 2014 +0100
files: Lib/test/test_asyncio/test_events.py
description:
asyncio: ops, and now fix also the unit test for IPv6
Yury Selivanov added the comment:
NEWS updates:
changeset: 89305:db749f0c6567
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Thu Feb 20 13:59:14 2014 -0500
files: Misc/NEWS
description:
Misc/NEWS: Add some missing news items re asyncio.
--
Yury Selivanov added the comment:
Again, documentation update.
changeset: 89306:1c35d3114ea1
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Thu Feb 20 14:10:02 2014 -0500
files: Doc/library/asyncio-stream.rst
description:
asyncio.docs: Improve
STINNER Victor added the comment:
changeset: 89307:96e078663083
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Thu Feb 20 21:59:38 2014 +0100
files: Lib/asyncio/base_events.py Lib/test/test_asyncio/test_events.py
description:
asyncio:
Larry Hastings added the comment:
I finished the second preview of rc2 just before you posted 96e078663083.
That'll go in the third preview.
Also, I found another revision you forgot about (something about improving
debug info). With that, and the other revisions I mentioned, asyncio in the
Yury Selivanov added the comment:
Hopefully, the last one from me ;) Again, some documentation updates.
Thank you, Larry, for accepting these last minute fixes.
changeset: 89308:cd23d0c3f850
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Thu Feb 20 16:20:44
Yury Selivanov added the comment:
Last bit of documentation from me.
I, personally, don't have any more changes in mind, so this one is probably the
last from me on the asyncio front in this thread.
changeset: 89312:ec3a70ef759d
tag: tip
user:Yury Selivanov
STINNER Victor added the comment:
changeset: 89269:9cfb3d1cf0d1
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Wed Feb 19 13:32:34 2014 +0100
files: Doc/library/asyncio-eventloop.rst
description:
asyncio: document new create_unix_connection() and
Yury Selivanov added the comment:
changeset: 89270:186f6f56f4bc
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Wed Feb 19 11:10:52 2014 -0500
files: Lib/asyncio/transports.py Lib/test/test_asyncio/test_transports.py
description:
asyncio:
STINNER Victor added the comment:
changeset: 89288:dbf13a7d3987
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Wed Feb 19 23:15:02 2014 +0100
files: Doc/library/asyncio-dev.rst Doc/library/asyncio-eventloop.rst
Doc/using/cmdline.rst Lib/asyncio/bas
STINNER Victor added the comment:
changeset: 89283:07cdce316b1d
user:Victor Stinner victor.stin...@gmail.com
date:Wed Feb 19 18:32:03 2014 +0100
files: Lib/test/test_asyncio/test_events.py
description:
Issue #20682: Oops, fix test_create_connection() of test_asyncio (fix
STINNER Victor added the comment:
changeset: 89290:549f451aa4c3
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Thu Feb 20 01:44:10 2014 +0100
files: Doc/library/asyncio-dev.rst Doc/library/asyncio-eventloop.rst
description:
asyncio doc: remove
Yury Selivanov added the comment:
Some documentation.
changeset: 89291:58fd64e55b29
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Wed Feb 19 20:58:44 2014 -0500
files: Doc/library/asyncio-eventloop.rst
description:
asyncio.docs: Document Error Handling
Larry Hastings added the comment:
*sigh* okay. Including 2e8a142dbccc from last night, that's eight new
revisions to cherry-pick in one day. I really hope this is slowing down.
--
___
Python tracker rep...@bugs.python.org
Yury Selivanov added the comment:
*sigh* okay. Including 2e8a142dbccc from last night, that's eight new
revisions to cherry-pick in one day. I really hope this is slowing down.
It is slowing down. I think we now only have some documentation updates left.
--
Vajrasky Kok added the comment:
It is slowing down. I think we now only have some documentation updates left.
What about this one? http://bugs.python.org/issue20668 (Remove dependency on
tests.txt when running test_asyncio suite)
It has been lgtm-ed by Guido and asked by him to be added to
Guido van Rossum added the comment:
That one is not critical. It can go in sfter 3.4 is released.
On Wednesday, February 19, 2014, Vajrasky Kok rep...@bugs.python.org
wrote:
Vajrasky Kok added the comment:
It is slowing down. I think we now only have some documentation updates
left.
Larry Hastings added the comment:
There are a few diffs on the asyncio files right now. I went back and looked
and discovered a whole bunch of asyncio revisions post-rc1 that you haven't
asked to be cherry-picked yet:
20dc8d6430eb
75881b85695f
9c1840e8d643
a631b01d1715
360976a6d8b9
Larry Hastings added the comment:
Also 6b850722849e
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20648
___
___
Python-bugs-list mailing list
STINNER Victor added the comment:
You may also cherry-pick d548829765cd and b2498889ad8d, skip tests on OpenBSD.
And:
changeset: 89246:6b09a2cf1744
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Tue Feb 18 09:22:00 2014 +0100
files:
STINNER Victor added the comment:
New changeset 79e5bb0d9b8e by Victor Stinner in branch 'default':
Issue #20493: Document that asyncio should not exceed one day
http://hg.python.org/cpython/rev/79e5bb0d9b8e
--
___
Python tracker
Yury Selivanov added the comment:
Two new cherry-picks:
changeset: 89253:d6c7d1f18915
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Tue Feb 18 12:21:57 2014 -0500
files: Misc/NEWS
description:
Misc/NEWS: Add a news item for UNIX Sockets support in
Guido van Rossum added the comment:
This one needs to be CP'ed together with Yuri's UNIX sockets one.
changeset: 89257:f81106f36656
tag: tip
user:Guido van Rossum gu...@python.org
date:Tue Feb 18 10:24:30 2014 -0800
summary: asyncio: Make tests pass on Windows.
Yury Selivanov added the comment:
changeset: 89262:7c1de1ebb894
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Tue Feb 18 18:02:19 2014 -0500
files: Lib/asyncio/base_events.py Lib/asyncio/events.py
Lib/asyncio/futures.py Lib/asyncio/proactor_events.py
Yury Selivanov added the comment:
http://hg.python.org/cpython/rev/72dba0d11235
changeset: 89263:72dba0d11235
user:Yury Selivanov yseliva...@sprymix.com
date:Tue Feb 18 18:41:13 2014 -0500
summary:
asyncio.transports: Make _ProactorBasePipeTransport use _FlowControlMixin
STINNER Victor added the comment:
changeset: 89264:2406566d2c04
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Wed Feb 19 01:40:41 2014 +0100
files: Lib/asyncio/proactor_events.py Lib/asyncio/selector_events.py
Lib/asyncio/unix_events.py
STINNER Victor added the comment:
changeset: 89265:089ce5ddc147
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Wed Feb 19 01:45:59 2014 +0100
files: Lib/asyncio/unix_events.py
Lib/test/test_asyncio/test_unix_events.py
description:
asyncio, Tulip issue
Yury Selivanov added the comment:
Minor stuff:
changeset: 89267:2b0e65df8821
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Tue Feb 18 22:27:48 2014 -0500
files: Lib/asyncio/events.py Lib/asyncio/protocols.py
Lib/asyncio/selector_events.p
description:
Yury Selivanov added the comment:
changeset: 89268:2e8a142dbccc
tag: tip
user:Yury Selivanov yseliva...@sprymix.com
date:Tue Feb 18 22:56:15 2014 -0500
files: Lib/asyncio/base_events.py Lib/asyncio/subprocess.py
Lib/test/test_asyncio/t
description:
asyncio:
Larry Hastings added the comment:
2e8a142dbccc just missed today's cherry-picking session. I'll add it tomorrow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20648
___
Guido van Rossum added the comment:
TBH I don't think typos or pep8 cleanups ought to be CP'ed...
On Tuesday, February 18, 2014, Larry Hastings rep...@bugs.python.org
wrote:
Larry Hastings added the comment:
2e8a142dbccc just missed today's cherry-picking session. I'll add it
tomorrow.
Larry Hastings added the comment:
Perhaps, but if they request cherry-picking for revisions after 2e8a142dbccc,
skipping 2e8a142dbccc will make the cherry-picking a lot harder.
And I bet I haven't seen the last request for cherry-picking asyncio changes
for 3.4.0.
--
Guido van Rossum added the comment:
Actually I am trying to quell the tide. :-). But nobody sent me a review
request for those...
On Tuesday, February 18, 2014, Larry Hastings rep...@bugs.python.org
wrote:
Larry Hastings added the comment:
Perhaps, but if they request cherry-picking for
Yury Selivanov added the comment:
Perhaps, but if they request cherry-picking for revisions after 2e8a142dbccc,
skipping 2e8a142dbccc will make the cherry-picking a lot harder.
Yes, it may make it harder, it's probably better to merge it (no functional
changes in it).
I now think that pep8
Larry Hastings added the comment:
For what it's worth,
Lib/asyncio/*
Lib/test/test_asyncio/*
Doc/library/async*
are all exactly the same between default and the tarball I published this
evening. (Minus Yury's cleanup patch of course.)
--
___
Guido van Rossum added the comment:
Thanks for checking!
On Tuesday, February 18, 2014, Larry Hastings rep...@bugs.python.org
wrote:
Larry Hastings added the comment:
For what it's worth,
Lib/asyncio/*
Lib/test/test_asyncio/*
Doc/library/async*
are all exactly the same between
STINNER Victor added the comment:
changeset: 89231:ea4c74cc4da5
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Mon Feb 17 10:54:30 2014 +0100
files: Doc/library/asyncio-task.rst
description:
Close #20652: asyncio doc: close the event loop in
Larry Hastings added the comment:
Yeah, I considered getting fussy about you didn't follow instructions. But
this actually is better for me, as it means I can apply the patches in
chronological order.
Like Guido said, I intend to be permissive when it comes to asyncio for 3.4.0.
I'm
STINNER Victor added the comment:
changeset: 89237:b3987d758e49
tag: tip
user:Victor Stinner victor.stin...@gmail.com
date:Tue Feb 18 00:11:21 2014 +0100
files: Lib/test/test_asyncio/tests.txt
description:
Issue #20655: Fix test_asyncio, run also subprocess tests.
New submission from STINNER Victor:
I consider that it's not too late to include these changes to Python 3.4 final
because asyncio module is new in Python 3.4. Very few people outside asyncio
developers are testing asyncio, so it's not surprising to see these changes
only recently. asyncio
Changes by STINNER Victor victor.stin...@gmail.com:
--
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20648
___
Yury Selivanov added the comment:
I think we should just ask Larry to merge all commits for asyncio in 3.4.
I.e. we won't commit anything that should not go in 3.4 anyways.
--
___
Python tracker rep...@bugs.python.org
Guido van Rossum added the comment:
Right, that has been my understanding. Larry has said he'd give asyncio a
generous exception because it's all new in 3.4.
On Sunday, February 16, 2014, Yury Selivanov rep...@bugs.python.org wrote:
Yury Selivanov added the comment:
I think we should just
Guido van Rossum added the comment:
Then again Larry might appreciate a full list of what to cherrypick.
On Sunday, February 16, 2014, Guido van Rossum rep...@bugs.python.org
wrote:
Guido van Rossum added the comment:
Right, that has been my understanding. Larry has said he'd give asyncio
54 matches
Mail list logo
