[issue20687] Change in expectedFailure breaks testtools

Cheryl Sabella added the comment: Larry suggested closing this as wontfix 5 years ago. Since testtools added code for this test and there hasn't been any other changes since, I'll close per his suggestion. -- nosy: +cheryl.sabella resolution: -> wont fix stage: -> resolved status:

[issue20687] Change in expectedFailure breaks testtools

Larry Hastings added the comment: Then I'm marking this as 3.5 and clearing the regression keyword. From here we can either fix it in 3.5 or not bother (and just close this issue as wontfix). -- keywords: -3.4regression priority: high -> normal versions: +Python 3.5 -Python 3.4 _

[issue20687] Change in expectedFailure breaks testtools

Antoine Pitrou added the comment: > Antoine: would it be reasonable to rework the implementation of > subTest in a way that permitted us to revert the changes to > expectedFailure? I can't tell you for sure, but certainly not in an easy way. Expected failures were the most delicate feature to k

[issue20687] Change in expectedFailure breaks testtools

Robert Collins added the comment: Oh! I didn't realise it was due to us looking at a private exception - I haven't been given a traceback to review, just the statement of a problem We shouldn't have done that(and *Definitely* should have filed a bug that we needed to). So - I think the qu

[issue20687] Change in expectedFailure breaks testtools

Changes by Larry Hastings : -- priority: release blocker -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20687] Change in expectedFailure breaks testtools

Larry Hastings added the comment: So here's the thing. It only works in Python 3.3 because testtools depends on internal implementation details of unittest, specifically a private exception ("unittest.case._UnexpectedSuccess"). The public interface still works fine. So I don't think this is

[issue20687] Change in expectedFailure breaks testtools

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue20687] Change in expectedFailure breaks testtools

Changes by Ezio Melotti : -- nosy: +ezio.melotti, michael.foord, pitrou type: -> behavior ___ Python tracker ___ ___ Python-bugs-list

[issue20687] Change in expectedFailure breaks testtools

Barry A. Warsaw added the comment: Bumping to release blocker so Larry can make a determination. -- nosy: +larry priority: normal -> release blocker ___ Python tracker ___ __

[issue20687] Change in expectedFailure breaks testtools

Robert Collins added the comment: I concur that this is a regression - " unittest.expectedFailure() Mark the test as an expected failure. If the test fails when run, the test is not counted as a failure. " is in the public docs for the unittest module, and depending on a private att

[issue20687] Change in expectedFailure breaks testtools

Changes by Barry A. Warsaw : -- nosy: +rbcollins ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20687] Change in expectedFailure breaks testtools

Changes by Thomi Richards : -- nosy: +thomir ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue20687] Change in expectedFailure breaks testtools

New submission from Barry A. Warsaw: The change for issue #16997 82844:5c09e1c57200 introduced a regression with testtools. See attached file and instructions for reproducing it (it requires the testtools package). -- components: Library (Lib) files: test_expected_failure.py keywords: