Thomas Kluyver added the comment:
For future reference, cx_Freeze ships its own copy of ModuleFinder, so it
doesn't depend on the stdlib copy. This issue was fixed there some time around
the release of Python 3.3.
I realised recently that this is based on code in the stdlib, and I've been
Roundup Robot added the comment:
New changeset 432cb56db05d by Brett Cannon in branch '3.3':
Issue #20778: Fix modulefinder to work with bytecode-only modules.
http://hg.python.org/cpython/rev/432cb56db05d
New changeset b6e999c8907c by Brett Cannon in branch 'default':
merge for issue #20778
Brett Cannon added the comment:
Fixed in Python 3.3.6 and 3.4.1.
Bohuslav, could you sign the contributor agreement at
http://www.python.org/psf/contrib/contrib-form/ ? While I didn't directly use
your patch this time I noticed you are already in Misc/ACKS so it would be
helpful if you could
Bohuslav Slavek Kabrda added the comment:
Brett, I signed it just yesterday, it probably wasn't processed yet. Hopefully
it will be in few days. Thanks for patching this!
--
resolution: fixed -
status: closed - open
___
Python tracker
Bohuslav Slavek Kabrda added the comment:
Whoops, reopened by accident. Closing again.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
New submission from Bohuslav Slavek Kabrda:
ModuleFinder.load_module currently only skips 8 bytes before trying to
marshal.load the rest of the file, but it should skip 12 since 3.3 (magic,
date, file size). I'm attaching a patch with test case.
BTW this was very painful to find out, since I
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
Brett Cannon added the comment:
It's not documented because the format of .pyc files is considered an internal
implementation detail.
--
nosy: +georg.brandl, larry
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
Changes by Brett Cannon br...@python.org:
--
priority: release blocker - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
___
Brett Cannon added the comment:
Probably want to make sure that modulefinder uses
importlib._bootstrap._validate_bytecode_header() to do the parsing.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
R. David Murray added the comment:
Since modulefinder is used by freeze tools (notably cx_Freeze, which seems to
be the most popular currently), should this be considered a release blocker?
--
nosy: +r.david.murray
___
Python tracker
Brett Cannon added the comment:
It's been broken since Python 3.3 so this is not a 3.3 regression.
--
keywords: +3.2regression -patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
R. David Murray added the comment:
Right. I'm asking if it should be a release blocker for the next 3.3, too :)
I'm not saying it should be, just raising the question. It's in my mind
because I'm currently using cx_Freeze in a project for a client. It could have
affected me, since I was
R. David Murray added the comment:
Oops, didn't mean to remove the keyword.
--
keywords: +3.2regression
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
Brett Cannon added the comment:
Don't know why this is any more special of a bug because it influences
cx_freeze compared to any other bug that influences a popular project. I mean
I'm not going to stop you from making it a blocker but I'm also not going to
rush to fix it myself either.
R. David Murray added the comment:
Well, because of the fact that freeze tools are used to distribute programs on
the Windows platform. But, given that it hasn't been reported before and has
been a problem since 3.3, it seems like there is no rush.
--
Changes by Larry Hastings la...@hastings.org:
--
nosy: -larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
keywords: +patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
keywords: +3.3regression -3.2regression, patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20778
___
20 matches
Mail list logo
