Roundup Robot added the comment:
New changeset 27a02eb9273f by R David Murray in branch '3.4':
#20815: small readability improvements in ipaddress tests.
https://hg.python.org/cpython/rev/27a02eb9273f
New changeset 4c9d27eef892 by R David Murray in branch 'default':
#20815: small readability
R. David Murray added the comment:
Since ipaddress is relatively new, the package maintainers approved the patch,
and it is mostly blank lines (and therefore not a problem with
annotate) I committed this. Thank Michel.
--
nosy: +r.david.murray
resolution: - fixed
stage: commit review
Raymond Hettinger added the comment:
Marking as low priority. This patch really isn't worth applying.
If someone wants to starting contributing, there are plenty of useful things to
do (such as adding docstrings to elementtree). I don't want to encourage
non-substantive shallow code churn
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: - commit review
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20815
___
Michel Albert added the comment:
It seems the contributor agreement form has been processed. As I understand it,
the asterisk on my name confirms this.
I also verified that this patch cleanly applies to the most recent revision.
--
___
Python
pmoody added the comment:
Will Do.
Michael, would you mind signing the contributor agreement so I can apply your
patch?
http://www.python.org/psf/contrib/contrib-form/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20815
Michel Albert added the comment:
Did so already last weekend. I suppose it will take some time to be processed.
I can ping you via a message here once I receive the confirmation.
--
___
Python tracker rep...@bugs.python.org
pmoody added the comment:
thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20815
___
___
Python-bugs-list mailing list
Unsubscribe:
pmoody added the comment:
Nick, did you want me to apply this?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20815
___
___
Python-bugs-list
Nick Coghlan added the comment:
Yeah, I like the small readability tweaks in the r3 patch, so feel free to
apply that one.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20815
___
Michel Albert added the comment:
I strongly agree with Raymond's points! They are all valid.
I should note, that I submitted this patch to - as mentioned by Nick -
familiarise myself with the patch submission process. I decided to make
harmless changes which won't risk braking anything.
Michel Albert added the comment:
Here's a new patch which addresses white-space issues without touching the old
tests.
--
Added file: http://bugs.python.org/file34265/test_ipaddress_pep8-r3.patch
___
Python tracker rep...@bugs.python.org
Raymond Hettinger added the comment:
FWIW, I consider this patch to be a waste of time and don't want to encourage
more patches like it. Please focus on substantive changes like improving test
coverage, adding documentation strings, etc.
Applying this patch would make a microscopic
Nick Coghlan added the comment:
I think there's still value in giving someone experience with the current patch
development process, as well as looking for potentially genuine readability
improvements.
However, I also agree that automated compliance with a style guide checker
can't sensibly
New submission from Michel Albert:
While I was looking at the source of the ipaddress unit-tests, I noticed a
couple of PEP8 violations. This patch fixes these (verified using the ``pep8``
tool).
There are no behavioural changes. Only white-space.
Test-cases ran successfully before, and
Nick Coghlan added the comment:
Unfortunately, the pep8 tool includes some additional invented rules of its
own, mostly related to being far too strict about indentation of continuation
lines.
PEP 8 is actually mostly silent on that topic, merely pointing out a couple of
specific things
Michel Albert added the comment:
Thanks for the quick reply!
I did not know the pep8 tool added it's own rules :( I have read PEP8 a long
while ago and have since relied on the tool to do the right thing. Many of
it's idiosyncrasies have probably made their way into my blood since :(
And
Nick Coghlan added the comment:
I'd suggest focusing more on the structured tests at the top of the file - the
ones further down we largely incorporated wholesale from the original ipaddr
project, and didn't go back and enforce PEP 8 compliance, but the new tests
should follow the style
18 matches
Mail list logo
