[issue20849] add exist_ok to shutil.copytree

Change by Giampaolo Rodola' : -- assignee: -> giampaolo.rodola resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker ___

[issue20849] add exist_ok to shutil.copytree

Giampaolo Rodola' added the comment: New changeset 9e00d9e88fbf943987e4771c753f5ca8f794103e by Giampaolo Rodola (jab) in branch 'master': bpo-20849: add dirs_exist_ok arg to shutil.copytree (patch by Josh Bronson)

[issue20849] add exist_ok to shutil.copytree

Joshua Bronson added the comment: I submitted a new PR in https://github.com/python/cpython/pull/8792 that addresses the outstanding concerns in @ofekmeister's original PR. It includes passing tests and passes all the GitHub PR status checks. Does it look ok to merge? Thanks. --

[issue20849] add exist_ok to shutil.copytree

Change by Joshua Bronson : -- nosy: +jab ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20849] add exist_ok to shutil.copytree

Giampaolo Rodola' added the comment: I think this feature request is reasonable for 2 reasons: 1) As it stands if dst directory exists copytree() cannot be used. The only possible workaround is using rmtree(dst) first, but that doesn't seem to make much sense. The change may look extremely

[issue20849] add exist_ok to shutil.copytree

Change by Joshua Bronson : -- pull_requests: +8266 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20849] add exist_ok to shutil.copytree

Change by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20849] add exist_ok to shutil.copytree

Changes by Ofek Lev : -- pull_requests: +3020 ___ Python tracker ___ ___

[issue20849] add exist_ok to shutil.copytree

Changes by Justin Myers jus...@justinmyers.net: -- nosy: +justin.myers ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20849 ___ ___

[issue20849] add exist_ok to shutil.copytree

Alexander Mohr added the comment: btw, I believe the solution is as simple as stated as that's what I'm doing locally and its behaving exactly as intended. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20849

[issue20849] add exist_ok to shutil.copytree

Alexander Mohr added the comment: Ya. The original request I think is ok because by allowing that flag it will replace files and dirs. On Mar 14, 2014 7:15 PM, R. David Murray rep...@bugs.python.org wrote: R. David Murray added the comment: I don't know what the method already allows for

[issue20849] add exist_ok to shutil.copytree

Éric Araujo added the comment: Adding some core devs to get their opinion on this proposal. -- nosy: +hynek, ncoghlan, r.david.murray, tarek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20849

[issue20849] add exist_ok to shutil.copytree

R. David Murray added the comment: I don't know what the method already allows for existing files means. Since the target directory can't exist, there can be no existing files. In unix, this kind of capability is provided by a combination of shell globbing and 'cp -r', and by default it does

[issue20849] add exist_ok to shutil.copytree

Alexander Mohr added the comment: how about instead we rename the new parameter to dirs_exists_ok or something like that since the method already allows for existing files. -- ___ Python tracker rep...@bugs.python.org

[issue20849] add exist_ok to shutil.copytree

Elias Zamaria added the comment: I am not sure. I am not on the python-ideas mailing list, and I am not sure what adding and maintaining the discussion would entail, or if I would have the time to do it or want to deal with the clutter in my inbox. I just committed this patch because it seemed

[issue20849] add exist_ok to shutil.copytree

Alexander Mohr added the comment: I personally dont think this is worth investing the time for a discussion. If the maintainers dont want to accept this or a minor variation without a discussion ill just keep my local monkeypatch :) thanks again for the quick patch Elias! On Mar 8, 2014 4:03

[issue20849] add exist_ok to shutil.copytree

Éric Araujo added the comment: Contrary to makedirs, there could be two interpretations for exist_ok in copytree: a) if a directory or file already exists in the destination, ignore it and go ahead b) only do that for directories. The proposed patch does b), but the cp tool does a). It’s

[issue20849] add exist_ok to shutil.copytree

Changes by Berker Peksag berker.pek...@gmail.com: -- stage: - patch review versions: -Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20849 ___

[issue20849] add exist_ok to shutil.copytree

Alexander Mohr added the comment: awesome, thanks so much!! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20849 ___ ___ Python-bugs-list

[issue20849] add exist_ok to shutil.copytree

New submission from Alexander Mohr: it would be REALLY nice (and REALLY easy) to add a parameter: exist_ok and pass this to os.makedirs with the same parameter name so you can use copytree to append a src dir to an existing dst dir. -- components: Library (Lib) messages: 212691 nosy:

[issue20849] add exist_ok to shutil.copytree

Elias Zamaria added the comment: Here is a patch that adds the option. I am not very familiar with the internals of shutil and os so I would recommend that someone else review it. I haven't added any tests. I can try to if anyone wants but I am not sure how long it will take me or if I will