[issue21032] Socket leak if HTTPConnection.getresponse() fails

Change by Felipe Rodrigues : -- nosy: +fbidu nosy_count: 3.0 -> 4.0 pull_requests: +21848 pull_request: https://github.com/python/cpython/pull/22737 ___ Python tracker ___

[issue21032] Socket leak if HTTPConnection.getresponse() fails

Serhiy Storchaka added the comment: What is the status of your contributor agreement Martin? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21032 ___

[issue21032] Socket leak if HTTPConnection.getresponse() fails

Martin Panter added the comment: Hi Serhiy, I submitted the form online on 22 Nov; just patiently waiting for it to come through now. In the last few minutes I noticed an asterisk has appeared against my name on the bug tracker, so hopefully it is all good now. --

[issue21032] Socket leak if HTTPConnection.getresponse() fails

Roundup Robot added the comment: New changeset 561d1d0de518 by Serhiy Storchaka in branch 'default': Issue #21032: Deprecated the use of re.LOCALE flag with str patterns or https://hg.python.org/cpython/rev/561d1d0de518 -- nosy: +python-dev ___

[issue21032] Socket leak if HTTPConnection.getresponse() fails

Roundup Robot added the comment: New changeset f88c00391dd8 by Serhiy Storchaka in branch '2.7': Issue #21032. Fixed socket leak if HTTPConnection.getresponse() fails. https://hg.python.org/cpython/rev/f88c00391dd8 New changeset ba72da4883eb by Serhiy Storchaka in branch '3.4': Issue #21032.

[issue21032] Socket leak if HTTPConnection.getresponse() fails

Serhiy Storchaka added the comment: Few notes about patches. Check patches for trailing spaces. And it would be more suitable if you provide single patch instead of a couple of patches. I have slightly changed the test, so it checks that the file is actually closed, not lost, The fix LGTM.

[issue21032] Socket leak if HTTPConnection.getresponse() fails

Serhiy Storchaka added the comment: Could you please submit a contributor form (https://www.python.org/psf/contrib/) Martin? -- assignee: - serhiy.storchaka nosy: +serhiy.storchaka stage: - patch review versions: +Python 3.5 ___ Python tracker

[issue21032] Socket leak if HTTPConnection.getresponse() fails

New submission from Martin Panter: Here is a regression test and patch to close the socket reader when a HTTP server causes getresponse() to fail, for instance if the server times out and drops the connection without sending any response. Without the patch the socket will only be closed by

[issue21032] Socket leak if HTTPConnection.getresponse() fails

Changes by Martin Panter vadmium...@gmail.com: Added file: http://bugs.python.org/file34580/close.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21032 ___