[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Change by Eryk Sun : -- Removed message: https://bugs.python.org/msg405701 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Change by Eryk Sun : -- components: +Library (Lib) -Subinterpreters nosy: -ahmedsayeed1982 ___ Python tracker ___ ___ Python-bugs-l

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Ahmed Sayeed added the comment: [gdb/breakpoints] Handle glibc with debuginfo in create_exception_master_breakpoint http://www-look-4.com/computers/huawei-computers/ The test-case nextoverthrow.exp is failing on targets with unstripped libc. https://komiya-dental.com/category/servi

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Benjamin Peterson added the comment: I've now removed the offending behavior. exist_ok is still racy because it uses path.isdir() in the exceptional case, but fixing that can be an enhancement elsewhere. -- nosy: +benjamin.peterson ___ Python tracke

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Roundup Robot added the comment: New changeset 9186f4a18584 by Benjamin Peterson in branch '3.2': remove directory mode check from makedirs (closes #21082) http://hg.python.org/cpython/rev/9186f4a18584 New changeset 6370d44013f7 by Benjamin Peterson in branch '3.3': merge 3.2 (#21082) http://hg.

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by jan matejek : -- nosy: +matejcik ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Serhiy Storchaka added the comment: See also issue19930. Behaviors of os.makedirs() and pathlib.Path.mkdir() are different. pathlib.Path.mkdir() (as the mkdir command) creates parent directories with default mode, and os.makedirs() - with specified mode. -- nosy: +serhiy.storchaka ___

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by Raymond Hettinger : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by koobs : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mail

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by Terry J. Reedy : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by Benjamin Peterson : -- priority: high -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by Remi Pointel : -- nosy: +rpointel ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

STINNER Victor added the comment: > I think the behaviour that an error is raised if the permissions are not the > same is a nuisance that does not correspond to actual use cases (*). I was also surprised that makedirs() checks for the exact permission. We can probably document that makedirs(e

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Antoine Pitrou added the comment: (note that Victor's patch is of course not an actual fix, only a mitigation; if someone is relying on a stricter umask they will still be vulnerable to this) -- ___ Python tracker

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Antoine Pitrou added the comment: I think the behaviour that an error is raised if the permissions are not the same is a nuisance that does not correspond to actual use cases (*). People who care about permissions so much that they expect an error can do the check themselves, or call chmod().

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

STINNER Victor added the comment: The shell command "umask" calls umask(022) to get the current umask, and then call umask() with result of the first call. 022 is the default umask, it's probably safer to call umask(0o22) in _get_masked_mode() instead of umask(0). Attached patch makes this ch

[issue21082] os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem

Changes by STINNER Victor : -- title: os.makedirs() is not thread-safe: umask is set temporary to 0, serious security problem -> os.makedirs(exist_ok=True) is not thread-safe: umask is set temporary to 0, serious security problem ___ Python tracker